You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/08/19 03:45:05 UTC

[GitHub] [incubator-tvm] masahi edited a comment on pull request #6298: [BUG_FIX] Fix resize test

masahi edited a comment on pull request #6298:
URL: https://github.com/apache/incubator-tvm/pull/6298#issuecomment-675829929


   Frontend tests are failing really bad with this change. We need to fix hardcoded
   https://github.com/apache/incubator-tvm/blob/0a4ee30da727ae1566a0541ba6ed726d48733cc7/python/tvm/relay/frontend/onnx.py#L935
   
   
   There is also bilinear + align_corners=False combination in tflite test, which translates to bilinear + asymmetric in Relay:
   https://github.com/apache/incubator-tvm/blob/77042327d944fbfa243f59740c087d433bc1569e/tests/python/frontend/tflite/test_forward.py#L1058
   
   I don't know what TF does with bilinear + align_corners=False. Also not sure if bilinear + asymmetric in Relay is a valid combination. Maybe @jwfromm @srkreddy1238 have thought on this? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org