You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/07/08 22:26:31 UTC

[GitHub] [geode] pivotal-eshu opened a new pull request #5358: GEODE-8326: remove 5 minutes wait to get stack dump

pivotal-eshu opened a new pull request #5358:
URL: https://github.com/apache/geode/pull/5358


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] pivotal-eshu commented on a change in pull request #5358: GEODE-8326: remove 5 minutes wait to get stack dump

Posted by GitBox <gi...@apache.org>.
pivotal-eshu commented on a change in pull request #5358:
URL: https://github.com/apache/geode/pull/5358#discussion_r452966429



##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/partitioned/fixed/FixedPartitioningWithTransactionDistributedTest.java
##########
@@ -238,7 +238,7 @@ private void forceClientMetadataUpdate(Region region) {
     ClientMetadataService clientMetadataService =
         ((InternalCache) clientCacheRule.getClientCache()).getClientMetadataService();
     clientMetadataService.scheduleGetPRMetaData((InternalRegion) region, true);
-    await().atMost(5, MINUTES).until(clientMetadataService::isMetadataStable);
+    await().atMost(5, HOURS).until(clientMetadataService::isMetadataStable);

Review comment:
       It is not reproducible in private/local build. We only need to have it to fail once, once the stack dump is triggered, we can/should change it back to default timeout.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5358: GEODE-8326: remove 5 minutes wait to get stack dump

Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5358:
URL: https://github.com/apache/geode/pull/5358#discussion_r453805506



##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/partitioned/fixed/FixedPartitioningWithTransactionDistributedTest.java
##########
@@ -238,7 +238,7 @@ private void forceClientMetadataUpdate(Region region) {
     ClientMetadataService clientMetadataService =
         ((InternalCache) clientCacheRule.getClientCache()).getClientMetadataService();
     clientMetadataService.scheduleGetPRMetaData((InternalRegion) region, true);
-    await().atMost(5, MINUTES).until(clientMetadataService::isMetadataStable);
+    await().atMost(5, HOURS).until(clientMetadataService::isMetadataStable);

Review comment:
       seems like this experiment could have been conducted in the PR pipeline, shouldn't have needed to merge to develop




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] pivotal-eshu merged pull request #5358: GEODE-8326: remove 5 minutes wait to get stack dump

Posted by GitBox <gi...@apache.org>.
pivotal-eshu merged pull request #5358:
URL: https://github.com/apache/geode/pull/5358


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] pivotal-eshu commented on pull request #5358: GEODE-8326: remove 5 minutes wait to get stack dump

Posted by GitBox <gi...@apache.org>.
pivotal-eshu commented on pull request #5358:
URL: https://github.com/apache/geode/pull/5358#issuecomment-656260343


   Thanks for pointing out the default timeout time. I have updated the test so that stack dump can be generated if failed again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] agingade commented on a change in pull request #5358: GEODE-8326: remove 5 minutes wait to get stack dump

Posted by GitBox <gi...@apache.org>.
agingade commented on a change in pull request #5358:
URL: https://github.com/apache/geode/pull/5358#discussion_r452541982



##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/partitioned/fixed/FixedPartitioningWithTransactionDistributedTest.java
##########
@@ -238,7 +238,7 @@ private void forceClientMetadataUpdate(Region region) {
     ClientMetadataService clientMetadataService =
         ((InternalCache) clientCacheRule.getClientCache()).getClientMetadataService();
     clientMetadataService.scheduleGetPRMetaData((InternalRegion) region, true);
-    await().atMost(5, MINUTES).until(clientMetadataService::isMetadataStable);
+    await().atMost(5, HOURS).until(clientMetadataService::isMetadataStable);

Review comment:
       5 hours is a long time...Will this change going to be merged to develop? Can the debug be tried with local/private build?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org