You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/07/21 18:05:45 UTC
[GitHub] flink pull request #4383: [hotfix] [optimizer] Normalize job plan operator f...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4383
[hotfix] [optimizer] Normalize job plan operator formatting
When printing the job plan the operator description is typically formatted as the operator name followed by the user given or generated function name in parenthesis. For example, "Reduce (My Function)".
This normalizes the node names to include a space between the operator and function names.
I have reviewed the subclasses of `AbstractOperatorDescriptor`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 20170221a_normalize_job_plan_operator_formatting
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4383.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4383
----
commit 4f49fe4f2aff51ebf074f146e27361e743231d9b
Author: Greg Hogan <co...@greghogan.com>
Date: 2017-07-21T17:47:13Z
[hotfix] [optimizer] Normalize job plan operator formatting
When printing the job plan the operator description is typically
formatted as the operator name followed by the user given or generated
function name in parenthesis. For example, "Reduce (My Function)".
This normalizes the node names to include a space between the operator
and function names.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4383
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4383
I think i prefer the version without a space, but I may just be looking at it from a metrics perspective (yay, one less special character to deal with).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4383
Thanks @greghogan!
---
[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4383
@zentol I'd estimate that to be a similar change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4383
@zentol @fhueske I am merging the change with the extra space since this looks to have been the original intent. I've looked at both forms without finding a strong preference.
---
[GitHub] flink pull request #4383: [hotfix] [optimizer] Normalize job plan operator f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4383
---
[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4383
Dropping the space may make it easier to fix the line splitting issue in the web UI. @fhueske thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4383
I have no strong opinion on this. Either way is fine as long as it is consistent ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4383
Just to mention the idea, would removing the space introduce more changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---