[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3203: Moved the ZooKeeper 3.5.x compatibility check to targets other than main

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on code in PR #3203:
URL: https://github.com/apache/accumulo/pull/3203#discussion_r1117047269


##########
.github/workflows/maven.yaml:
##########
@@ -110,6 +109,12 @@ jobs:
       run: mvn -B -V -e -ntp "-Dstyle.color=always" -DskipFormat ${{ matrix.profile.args }}
       env:
         MAVEN_OPTS: -Djansi.force=true
+    - name: Build with Maven (ZooKeeper compatibility build)
+      if: ${{ github.base_ref != 'main' }}

Review Comment:
   Why exclude main?



##########
.github/workflows/maven.yaml:
##########
@@ -110,6 +109,12 @@ jobs:
       run: mvn -B -V -e -ntp "-Dstyle.color=always" -DskipFormat ${{ matrix.profile.args }}
       env:
         MAVEN_OPTS: -Djansi.force=true
+    - name: Build with Maven (ZooKeeper compatibility build)
+      if: ${{ github.base_ref != 'main' }}
+      timeout-minutes: 60
+      run: mvn -B -V -e -ntp "-Dstyle.color=always" -DskipFormat package -DskipTests -Dhadoop.version=3.0.3 -Dzookeeper.version=3.5.10
+      env:

Review Comment:
   This just puts inline what we have previously defined elsewhere. It seems the reason to do this is to exclude the main branch, and not use the normal args, but I'm not sure why we're excluding the main branch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org