You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/01/31 10:31:46 UTC

[GitHub] [libcloud] Kami commented on a change in pull request #1651: Personality field in the server requests of OpenStack must be optional

Kami commented on a change in pull request #1651:
URL: https://github.com/apache/libcloud/pull/1651#discussion_r795535859



##########
File path: libcloud/test/compute/test_openstack.py
##########
@@ -2755,6 +2770,35 @@ def _v1_1_slug_servers_EX_DISK_CONFIG(self, method, url, body, headers):
                 httplib.responses[httplib.OK],
             )
 
+    def _v1_1_slug_servers_EX_FILES(self, method, url, body, headers):
+        if method == "POST":
+            body = u(body)
+            personality = (
+                '"personality": ['

Review comment:
       Probably a bit more robust way would be to json.dumps the expected body and json.loads the response and compare the parsed dicts (otherwise the assertion may break in case we change the json library or similar).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org