You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "chenlushun (GitHub)" <gi...@apache.org> on 2019/04/09 13:21:11 UTC
[GitHub] [incubator-dubbo] chenlushun opened pull request #3838:
polish code and add javadoc
polish code and add javadoc
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3838 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3838:
polish code and fix (#3761)
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3838?src=pr&el=h1) Report
> Merging [#3838](https://codecov.io/gh/apache/incubator-dubbo/pull/3838?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/a378a019949d5989e3e8a54e0e02b8a9f68745be?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `76.47%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3838?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3838 +/- ##
============================================
- Coverage 63.6% 63.57% -0.03%
Complexity 71 71
============================================
Files 708 708
Lines 31192 31191 -1
Branches 5048 5048
============================================
- Hits 19839 19831 -8
- Misses 9072 9081 +9
+ Partials 2281 2279 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3838?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/dubbo/cache/support/jcache/JCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3838/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC9qY2FjaGUvSkNhY2hlLmphdmE=) | `86.95% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...data/definition/builder/CollectionTypeBuilder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3838/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLWRlZmluaXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL2RlZmluaXRpb24vYnVpbGRlci9Db2xsZWN0aW9uVHlwZUJ1aWxkZXIuamF2YQ==) | `47.61% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...api/src/main/java/org/apache/dubbo/rpc/Filter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3838/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9GaWx0ZXIuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...bo/metadata/definition/model/MethodDefinition.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3838/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLWRlZmluaXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL2RlZmluaXRpb24vbW9kZWwvTWV0aG9kRGVmaW5pdGlvbi5qYXZh) | `39.28% <0%> (ø)` | `8 <0> (ø)` | :arrow_down: |
| [...bo/metadata/definition/builder/MapTypeBuilder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3838/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLWRlZmluaXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL2RlZmluaXRpb24vYnVpbGRlci9NYXBUeXBlQnVpbGRlci5qYXZh) | `47.61% <0%> (ø)` | `5 <0> (ø)` | :arrow_down: |
| [...bo/cache/support/threadlocal/ThreadLocalCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3838/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC90aHJlYWRsb2NhbC9UaHJlYWRMb2NhbENhY2hlLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...he/dubbo/cache/support/expiring/ExpiringCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3838/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC9leHBpcmluZy9FeHBpcmluZ0NhY2hlLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...o/metadata/definition/builder/EnumTypeBuilder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3838/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLWRlZmluaXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL2RlZmluaXRpb24vYnVpbGRlci9FbnVtVHlwZUJ1aWxkZXIuamF2YQ==) | `75% <100%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...bbo/validation/support/jvalidation/JValidator.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3838/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci12YWxpZGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby92YWxpZGF0aW9uL3N1cHBvcnQvanZhbGlkYXRpb24vSlZhbGlkYXRvci5qYXZh) | `79.87% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/cache/support/expiring/ExpiringMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3838/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC9leHBpcmluZy9FeHBpcmluZ01hcC5qYXZh) | `40.35% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3838/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3838?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3838?src=pr&el=footer). Last update [a378a01...51e32b0](https://codecov.io/gh/apache/incubator-dubbo/pull/3838?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3838 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org