You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/02/19 09:05:13 UTC

[GitHub] [cordova-ios] brodybits opened a new pull request #795: breaking: *-Info.plist config fixes and improvements

brodybits opened a new pull request #795: breaking: *-Info.plist config fixes and improvements
URL: https://github.com/apache/cordova-ios/pull/795
 
 
   This is proposed to include and supersede PR #765, as a solution for #764, with some additional fixes and test updates that I think should be included at the same time.
   
   - updates and improvements to unit testing of projectFile parse method, now with xcworkspace included in the "ios-config-xml" fixture
   - include all changes from PR #765 so far, with possible solution to issue #764
   - some followup fixes to PR #765
   - add test cases for the code updated in PR #765
   - some more general improvements
   
   This proposal should be considered breaking since it now depends on existence of xcworkspace with the correct name. This should have been present in generated platforms/ios project for years.
   
   I have discussed some other related issues with plists in #793, not sure whether or not this proposal would resolve any such related issues.
   
   I would like to have multiple reviews before getting this proposal merged. I think it should be good to merge this with a squash merge, with all co-authored-by credits that I gave in 8dfeedc8f754f7638b96b6677a0f34a4d246c8c5, maybe with a rebase to cleanup some of the items that will go into the commit message.
   
   closes #765 (PR #765)
   resolves #764
   
   /cc @leogoesger

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova-ios] codecov-io edited a comment on issue #795: breaking: *-Info.plist config fixes and improvements

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #795: breaking: *-Info.plist config fixes and improvements
URL: https://github.com/apache/cordova-ios/pull/795#issuecomment-588140917
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/795?src=pr&el=h1) Report
   > Merging [#795](https://codecov.io/gh/apache/cordova-ios/pull/795?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/4ac155251e78b59ea74c91f29ab0353721dba475?src=pr&el=desc) will **increase** coverage by `0.11%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/795/graphs/tree.svg?width=650&token=WomDD5jInz&height=150&src=pr)](https://codecov.io/gh/apache/cordova-ios/pull/795?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #795      +/-   ##
   ==========================================
   + Coverage   74.36%   74.47%   +0.11%     
   ==========================================
     Files          13       13              
     Lines        1845     1853       +8     
   ==========================================
   + Hits         1372     1380       +8     
     Misses        473      473
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/795?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/scripts/cordova/lib/projectFile.js](https://codecov.io/gh/apache/cordova-ios/pull/795/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3Byb2plY3RGaWxlLmpz) | `95.31% <100%> (+0.66%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/795?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/795?src=pr&el=footer). Last update [4ac1552...b2496e3](https://codecov.io/gh/apache/cordova-ios/pull/795?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova-ios] codecov-io commented on issue #795: breaking: *-Info.plist config fixes and improvements

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #795: breaking: *-Info.plist config fixes and improvements
URL: https://github.com/apache/cordova-ios/pull/795#issuecomment-588140917
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/795?src=pr&el=h1) Report
   > Merging [#795](https://codecov.io/gh/apache/cordova-ios/pull/795?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/4ac155251e78b59ea74c91f29ab0353721dba475?src=pr&el=desc) will **increase** coverage by `0.11%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/795/graphs/tree.svg?width=650&token=WomDD5jInz&height=150&src=pr)](https://codecov.io/gh/apache/cordova-ios/pull/795?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #795      +/-   ##
   ==========================================
   + Coverage   74.36%   74.47%   +0.11%     
   ==========================================
     Files          13       13              
     Lines        1845     1853       +8     
   ==========================================
   + Hits         1372     1380       +8     
     Misses        473      473
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/795?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/scripts/cordova/lib/projectFile.js](https://codecov.io/gh/apache/cordova-ios/pull/795/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3Byb2plY3RGaWxlLmpz) | `95.31% <100%> (+0.66%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/795?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/795?src=pr&el=footer). Last update [4ac1552...b2496e3](https://codecov.io/gh/apache/cordova-ios/pull/795?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org