You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2023/08/09 16:01:02 UTC
[GitHub] [doris] morningman commented on a diff in pull request #22702: [feature](information_schema)add simple_tables for quickly get catlogs,db,table and add profiling table in order to Compatible with mysql
morningman commented on code in PR #22702:
URL: https://github.com/apache/doris/pull/22702#discussion_r1288798367
##########
gensrc/thrift/Descriptors.thrift:
##########
@@ -117,7 +117,9 @@ enum TSchemaTableType {
SCH_ROWSETS,
SCH_BACKENDS,
SCH_COLUMN_STATISTICS,
- SCH_PARAMETERS;
+ SCH_PARAMETERS,
+ SCH_SIMPLE_TABLES,
Review Comment:
```suggestion
SCH_SIMPLE_TABLES,
```
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -424,6 +429,10 @@ public class SessionVariable implements Serializable, Writable {
@VariableMgr.VarAttr(name = INSERT_TIMEOUT)
public int insertTimeoutS = 14400;
+ //query internal.information_schema.simple_tables time
+ @VariableMgr.VarAttr(name = QUERY_SIMPLE_TABLES_TIMEOUT)
+ public int querySimpleTablesTimeout = 3;
Review Comment:
I think it can be a FE config, not session variable.
Because we always set it globally
##########
gensrc/thrift/Descriptors.thrift:
##########
@@ -117,7 +117,9 @@ enum TSchemaTableType {
SCH_ROWSETS,
SCH_BACKENDS,
SCH_COLUMN_STATISTICS,
- SCH_PARAMETERS;
+ SCH_PARAMETERS,
+ SCH_SIMPLE_TABLES,
+ SCH_PROFILING;
Review Comment:
```suggestion
SCH_PROFILING;
```
##########
gensrc/thrift/FrontendService.thrift:
##########
@@ -351,6 +353,14 @@ struct TListTableStatusResult {
1: required list<TTableStatus> tables
}
+struct TSimpleTableStatus {
+ 1: required string name
Review Comment:
use 4 spaces instead of tab.
and use `optional` instead of `required`
##########
gensrc/thrift/FrontendService.thrift:
##########
@@ -351,6 +353,14 @@ struct TListTableStatusResult {
1: required list<TTableStatus> tables
}
+struct TSimpleTableStatus {
+ 1: required string name
+ 2: required i64 id
+}
+struct TListSimpleTableStatusResult {
+ 1: required list<TSimpleTableStatus> tables
Review Comment:
ditto
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/SchemaTable.java:
##########
@@ -379,37 +379,65 @@ public class SchemaTable extends Table {
.column("COLLATION_CONNECTION", ScalarType.createVarchar(32))
.column("DATABASE_COLLATION", ScalarType.createVarchar(32)).build()))
.put("rowsets", new SchemaTable(SystemIdGenerator.getNextId(), "rowsets", TableType.SCHEMA,
- builder().column("BACKEND_ID", ScalarType.createType(PrimitiveType.BIGINT))
- .column("ROWSET_ID", ScalarType.createVarchar(64))
- .column("TABLET_ID", ScalarType.createType(PrimitiveType.BIGINT))
- .column("ROWSET_NUM_ROWS", ScalarType.createType(PrimitiveType.BIGINT))
- .column("TXN_ID", ScalarType.createType(PrimitiveType.BIGINT))
- .column("NUM_SEGMENTS", ScalarType.createType(PrimitiveType.BIGINT))
- .column("START_VERSION", ScalarType.createType(PrimitiveType.BIGINT))
- .column("END_VERSION", ScalarType.createType(PrimitiveType.BIGINT))
- .column("INDEX_DISK_SIZE", ScalarType.createType(PrimitiveType.BIGINT))
- .column("DATA_DISK_SIZE", ScalarType.createType(PrimitiveType.BIGINT))
- .column("CREATION_TIME", ScalarType.createType(PrimitiveType.BIGINT))
- .column("NEWEST_WRITE_TIMESTAMP", ScalarType.createType(PrimitiveType.BIGINT))
- .build()))
+ builder().column("BACKEND_ID", ScalarType.createType(PrimitiveType.BIGINT))
+ .column("ROWSET_ID", ScalarType.createVarchar(64))
+ .column("TABLET_ID", ScalarType.createType(PrimitiveType.BIGINT))
+ .column("ROWSET_NUM_ROWS", ScalarType.createType(PrimitiveType.BIGINT))
+ .column("TXN_ID", ScalarType.createType(PrimitiveType.BIGINT))
+ .column("NUM_SEGMENTS", ScalarType.createType(PrimitiveType.BIGINT))
+ .column("START_VERSION", ScalarType.createType(PrimitiveType.BIGINT))
+ .column("END_VERSION", ScalarType.createType(PrimitiveType.BIGINT))
+ .column("INDEX_DISK_SIZE", ScalarType.createType(PrimitiveType.BIGINT))
+ .column("DATA_DISK_SIZE", ScalarType.createType(PrimitiveType.BIGINT))
+ .column("CREATION_TIME", ScalarType.createType(PrimitiveType.BIGINT))
+ .column("NEWEST_WRITE_TIMESTAMP", ScalarType.createType(PrimitiveType.BIGINT))
+ .build()))
.put("parameters", new SchemaTable(SystemIdGenerator.getNextId(), "parameters", TableType.SCHEMA,
- builder().column("SPECIFIC_CATALOG", ScalarType.createVarchar(64))
- .column("SPECIFIC_SCHEMA", ScalarType.createVarchar(64))
- .column("SPECIFIC_NAME", ScalarType.createVarchar(64))
- .column("ORDINAL_POSITION", ScalarType.createVarchar(77))
- .column("PARAMETER_MODE", ScalarType.createVarchar(77))
- .column("PARAMETER_NAME", ScalarType.createVarchar(77))
- .column("DATA_TYPE", ScalarType.createVarchar(64))
- .column("CHARACTER_OCTET_LENGTH", ScalarType.createVarchar(64))
- .column("NUMERIC_PRECISION", ScalarType.createVarchar(512))
- .column("NUMERIC_SCALE", ScalarType.createVarchar(64))
- .column("DATETIME_PRECISION", ScalarType.createVarchar(64))
- .column("CHARACTER_SET_NAME", ScalarType.createVarchar(256))
- .column("COLLATION_NAME", ScalarType.createVarchar(64))
- .column("DTD_IDENTIFIER", ScalarType.createVarchar(64))
- .column("ROUTINE_TYPE", ScalarType.createVarchar(64))
- .column("DATA_TYPEDTD_IDENDS", ScalarType.createVarchar(64))
- .build()))
+ builder().column("SPECIFIC_CATALOG", ScalarType.createVarchar(64))
+ .column("SPECIFIC_SCHEMA", ScalarType.createVarchar(64))
+ .column("SPECIFIC_NAME", ScalarType.createVarchar(64))
+ .column("ORDINAL_POSITION", ScalarType.createVarchar(77))
+ .column("PARAMETER_MODE", ScalarType.createVarchar(77))
+ .column("PARAMETER_NAME", ScalarType.createVarchar(77))
+ .column("DATA_TYPE", ScalarType.createVarchar(64))
+ .column("CHARACTER_OCTET_LENGTH", ScalarType.createVarchar(64))
+ .column("NUMERIC_PRECISION", ScalarType.createVarchar(512))
+ .column("NUMERIC_SCALE", ScalarType.createVarchar(64))
+ .column("DATETIME_PRECISION", ScalarType.createVarchar(64))
+ .column("CHARACTER_SET_NAME", ScalarType.createVarchar(256))
+ .column("COLLATION_NAME", ScalarType.createVarchar(64))
+ .column("DTD_IDENTIFIER", ScalarType.createVarchar(64))
+ .column("ROUTINE_TYPE", ScalarType.createVarchar(64))
+ .column("DATA_TYPEDTD_IDENDS", ScalarType.createVarchar(64))
+ .build()))
+ .put("simple_tables", new SchemaTable(SystemIdGenerator.getNextId(), "simple_tables", TableType.SCHEMA,
Review Comment:
how about just name it as `metadata_name_ids`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org