[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7011: Core: Store split offset for delete files

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #7011:
URL: https://github.com/apache/iceberg/pull/7011#discussion_r1126818465


##########
core/src/main/java/org/apache/iceberg/FileMetadata.java:
##########
@@ -192,6 +196,15 @@ public Builder withMetrics(Metrics metrics) {
       return this;
     }
 
+    public Builder withSplitOffsets(List<Long> offsets) {
+      if (offsets != null) {
+        this.splitOffsets = copyList(offsets);

Review Comment:
   In that case can we move this to a util class?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org