You are viewing a plain text version of this content. The canonical link for it is here.

Posted to server-dev@james.apache.org by Tung Tran Van <tu...@gmail.com> on 2021/10/06 09:00:18 UTC

Re: Remove GroupMembershipResolver and related implement?

This pull request has been approved and merged.
https://github.com/apache/james-project/pull/670

Cheer,
Tung

On Fri, Sep 24, 2021 at 2:21 PM Tung Tran Van <tu...@gmail.com> wrote:

> Hello all,
>
> I propose to remove `org.apache.james.mailbox.acl.GroupMembershipResolver`
> , `SimpleGroupMembershipResolver` and related implement.
>
> Reason:
>
> - Interface GroupMembershipResolver has only one implement is
> SimpleGroupMembershipResolver As the author's comment: "There is no
> persistence. You will get only what you add".
>
> And nowhere in James call to `.addMemberShip` method => `.isMember` always
> return FALSE.
>
> Remove the exuberancy code to make it simpler.
>
>
> Regards,
>
> Tung Tran Van
>
>
>

-- 
Tung, Tran Van
*Phone:* (+84) 35 757 6258
*Skype:* tung.tv202