You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/02/10 19:15:27 UTC
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7354: GEODE-10032: Add Category to RadishCommandType
dschneider-pivotal commented on a change in pull request #7354:
URL: https://github.com/apache/geode/pull/7354#discussion_r804026572
##########
File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/commands/RedisCommandType.java
##########
@@ -477,4 +568,10 @@ public RedisResponse executeCommand(Command command,
return commandExecutor.executeCommand(command, executionHandlerContext);
}
+
+ public static List<RedisCommandType> getCommandsForCategory(Category type) {
+ return Arrays.stream(RedisCommandType.values())
+ .filter(c -> c.category == type && c.category != Category.IGNORED)
Review comment:
why do you need "&& c.category != IGNORED"? If it is "== type" then it would not be IGNORED since "type" would never be IGNORED.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org