You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (Jira)" <ji...@apache.org> on 2020/04/02 17:06:00 UTC

[jira] [Commented] (ARROW-8315) [Python][Dataset] Don't rely on ordered dict keys in test_dataset.py

    [ https://issues.apache.org/jira/browse/ARROW-8315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073905#comment-17073905 ] 

Wes McKinney commented on ARROW-8315:
-------------------------------------

I recommend not using dict-based table construction at all in unit tests. Use the {{table($LIST, names=$LIST)}} method

> [Python][Dataset] Don't rely on ordered dict keys in test_dataset.py
> --------------------------------------------------------------------
>
>                 Key: ARROW-8315
>                 URL: https://issues.apache.org/jira/browse/ARROW-8315
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Python
>    Affects Versions: 0.16.0
>            Reporter: Ben Kietzman
>            Assignee: Antoine Pitrou
>            Priority: Minor
>              Labels: dataset, pull-request-available
>             Fix For: 0.17.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Python 3.5 does not guarantee insertion order of dict keys, so we can't rely on it when constructing tables in test_dataset.py
> https://github.com/apache/arrow/pull/6809/checks?check_run_id=554945477#step:6:2166



--
This message was sent by Atlassian Jira
(v8.3.4#803005)