You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by omefire <gi...@git.apache.org> on 2016/04/19 20:57:02 UTC
[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-medic/pull/94
CB-10475 (cordova-plugin-contacts) Grant 'Contacts' permissions while…
… running on iOS simulator
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-medic CB-10475
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-medic/pull/94.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #94
----
commit 9f873ac80e52388faeb24cca6afcc0ba2ac20e29
Author: Omar Mefire <om...@gmail.com>
Date: 2016-04-19T18:54:25Z
CB-10475 (cordova-plugin-contacts) Grant 'Contacts' permissions while running on iOS simulator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...
Posted by alsorokin <gi...@git.apache.org>.
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/94#discussion_r60492470
--- Diff: lib/util.js ---
@@ -74,24 +81,95 @@ module.exports = (function () {
return numDevices;
}
+ function getSimId() {
+ var findSimCommand = "cordova run --list --emulator | grep ^iPhone | tail -n1";
--- End diff --
If it's not too hard to implement, i think it would be good to also handle iPad simulators.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/94#issuecomment-212074104
This PR ports part of the following paramedic PR to medic:
https://github.com/apache/cordova-paramedic/pull/4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/94#discussion_r60300110
--- Diff: lib/medicPermissions.js ---
@@ -0,0 +1,63 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path = require('path');
+var fs = require('fs');
--- End diff --
nitpick: spacing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/94#issuecomment-212592382
Rebased on top of master and ready to be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/94#issuecomment-212074252
@sarangan12 could you please review ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/94
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/94#discussion_r60300760
--- Diff: lib/medicPermissions.js ---
@@ -0,0 +1,63 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path = require('path');
+var fs = require('fs');
+var shelljs = require("shelljs");
+//var logger = require('./utils').logger;
+var util = require("./util");
+
+function MedicPermissions(appName, simulatorsFolder, tccDbPath) {
+ this.appName = appName;
+ this.simulatorsFolder = simulatorsFolder;
+ this.tccDbPath = tccDbPath;
+}
+
+MedicPermissions.prototype.updatePermissions = function(serviceList) {
--- End diff --
Though this will work, you could modify the logic as
1. Check for existence of TCC.db file. If not copy an empty file.
2. Do the insert command.
This will simplify the logic. Refer my latest paramedic PR for details. Also, you could reuse the same logic for finding simId instead of copying it for all simulators.
Also, minor code changes for running the command is required. Refer latest paramedic PR for details
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/94#issuecomment-213118959
Related PR: https://github.com/apache/cordova-medic/pull/96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org