You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/09 08:01:17 UTC
[GitHub] [ozone] wzhallright opened a new pull request #2319: HDDS-5324. Shouldn't decNumKeys when delete keys fail
wzhallright opened a new pull request #2319:
URL: https://github.com/apache/ozone/pull/2319
## What changes were proposed in this pull request?
Now, regardless of whether the delete keys succeeds or fails, always dec num of keys.
So, the keys in the metric may be negative.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5324
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2319: HDDS-5324. Shouldn't decNumKeys when delete keys fail
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2319:
URL: https://github.com/apache/ozone/pull/2319#discussion_r648185122
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysDeleteRequest.java
##########
@@ -220,7 +220,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
}
break;
case FAILURE:
- omMetrics.decNumKeys(deleteKeys.size());
Review comment:
We can remove that unnecessary call. I am fine with it. You can update the Jira description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2319: HDDS-5324. Shouldn't decNumKeys when delete keys fail
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2319:
URL: https://github.com/apache/ozone/pull/2319#discussion_r648157399
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysDeleteRequest.java
##########
@@ -220,7 +220,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
}
break;
case FAILURE:
- omMetrics.decNumKeys(deleteKeys.size());
Review comment:
// reset deleteKeys as request failed.
deleteKeys = new ArrayList<>();
So, even without this fix also I don't see an issue. Have you observed any issue?
Or you want to avoid unnecessary call to decNumKeys is this the reason for PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 merged pull request #2319: HDDS-5324. Delete unnecessary calls to decNumKeys in OMKeysDeleteRequest
Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #2319:
URL: https://github.com/apache/ozone/pull/2319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] wzhallright commented on a change in pull request #2319: HDDS-5324. Delete unnecessary calls to decNumKeys in OMKeysDeleteRequest
Posted by GitBox <gi...@apache.org>.
wzhallright commented on a change in pull request #2319:
URL: https://github.com/apache/ozone/pull/2319#discussion_r648190704
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysDeleteRequest.java
##########
@@ -220,7 +220,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
}
break;
case FAILURE:
- omMetrics.decNumKeys(deleteKeys.size());
Review comment:
Thanks, PTAL!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] wzhallright commented on a change in pull request #2319: HDDS-5324. Shouldn't decNumKeys when delete keys fail
Posted by GitBox <gi...@apache.org>.
wzhallright commented on a change in pull request #2319:
URL: https://github.com/apache/ozone/pull/2319#discussion_r648182609
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysDeleteRequest.java
##########
@@ -220,7 +220,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
}
break;
case FAILURE:
- omMetrics.decNumKeys(deleteKeys.size());
Review comment:
I will modify the title if necessary, otherwise I will close this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on pull request #2319: HDDS-5324. Delete unnecessary calls to decNumKeys in OMKeysDeleteRequest
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #2319:
URL: https://github.com/apache/ozone/pull/2319#issuecomment-860344052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] wzhallright commented on a change in pull request #2319: HDDS-5324. Shouldn't decNumKeys when delete keys fail
Posted by GitBox <gi...@apache.org>.
wzhallright commented on a change in pull request #2319:
URL: https://github.com/apache/ozone/pull/2319#discussion_r648179694
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysDeleteRequest.java
##########
@@ -220,7 +220,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
}
break;
case FAILURE:
- omMetrics.decNumKeys(deleteKeys.size());
Review comment:
Thanks for review, sorry for i overlooked it in catch.
If in order to avoid unnecessary calls to decNumKeys, is it necessary to delete it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org