You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/03/30 00:48:57 UTC

[GitHub] [druid] clintropolis commented on a change in pull request #11045: add minimal documentation for expression filters

clintropolis commented on a change in pull request #11045:
URL: https://github.com/apache/druid/pull/11045#discussion_r603617631



##########
File path: docs/querying/filters.md
##########
@@ -531,3 +531,18 @@ The true filter is a filter which matches all values.  It can be used to tempora
 
 { "type" : "true" }
 ```
+
+### Expression Filter
+The expression is a filter that allows for the implementation of arbitrary conditions by leveraging druids existing expression system. This filter might be less performant than a combination of the other filters on this page due to the fact that not all filter optimizations are in place yet. 

Review comment:
       nit: Druid should be capitalized + minor suggestion
   ```suggestion
   The expression filter allows for the implementation of arbitrary conditions, leveraging the Druid expression system. This filter might be less performant than a combination of the other filters on this page due to the fact that not all filter optimizations are in place yet.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org