[GitHub] [jena] berezovskyi commented on a change in pull request #1131: Update log4j2. Clarify logging included artifacts in shading.

[GitBox <gi...@apache.org>]

berezovskyi commented on a change in pull request #1131:
URL: https://github.com/apache/jena/pull/1131#discussion_r768716428



##########
File path: jena-fuseki2/jena-fuseki-geosparql/pom.xml
##########
@@ -98,6 +98,17 @@
           <artifactId>log4j-slf4j-impl</artifactId>
         </dependency>
 
+        <!-- Put in to ensure the dependency isn't optional. -->
+        <dependency>
+          <groupId>org.apache.logging.log4j</groupId>
+          <artifactId>log4j-api</artifactId>
+        </dependency>
+
+        <dependency>
+          <groupId>org.apache.logging.log4j</groupId>
+          <artifactId>log4j-core</artifactId>

Review comment:
       I think `<scope>runtime</scope>` can be added to this dependency and other `-impl` dependencies as logging code should only directly depend on the `api`. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org