Re: [PR] KAFKA-16689: Move LogValidatorTest to storage module [kafka]

["chia7712 (via GitHub)" <gi...@apache.org>]

chia7712 commented on code in PR #16167:
URL: https://github.com/apache/kafka/pull/16167#discussion_r1657098300


##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##########
@@ -63,6 +63,8 @@ public interface MetricsRecorder {
         void recordInvalidChecksums();
 
         void recordNoKeyCompactedTopic();
+        // Visible for test
+        Long meterCount(String metricName);

Review Comment:
   we don't need to change the interface. you can have a specific impl which can return `meterCount`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org