You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Christian Schneider (JIRA)" <ji...@apache.org> on 2012/10/26 14:39:12 UTC
[jira] [Created] (DOSGI-134) Refactoring of TopologyManager
Christian Schneider created DOSGI-134:
-----------------------------------------
Summary: Refactoring of TopologyManager
Key: DOSGI-134
URL: https://issues.apache.org/jira/browse/DOSGI-134
Project: CXF Distributed OSGi
Issue Type: Bug
Affects Versions: 1.3.1
Reporter: Christian Schneider
Assignee: Christian Schneider
Fix For: 1.4
Currently the topology manager project contains a lot of cycles between the classes. The code is also rather difficult to understand.
I have prepared a refactoring to resolve the cycles and make the code a lot more readable. As the changes are pretty big I will first add a patch and wait for some feedback.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DOSGI-134) Refactoring of TopologyManager
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DOSGI-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485001#comment-13485001 ]
Christian Schneider commented on DOSGI-134:
-------------------------------------------
Added an Architecture overview for the TopologyManager project (after refactoring)
https://cwiki.apache.org/confluence/download/attachments/30739778/cxf+dosgi+topology+manager.png?version=2&modificationDate=1351265413000
> Refactoring of TopologyManager
> ------------------------------
>
> Key: DOSGI-134
> URL: https://issues.apache.org/jira/browse/DOSGI-134
> Project: CXF Distributed OSGi
> Issue Type: Bug
> Affects Versions: 1.3.1
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 1.4
>
> Attachments: DOSGI-134-1.patch, org.apache.cxf.dosgi.topologymanager-after.png
>
>
> Currently the topology manager project contains a lot of cycles between the classes. The code is also rather difficult to understand.
> I have prepared a refactoring to resolve the cycles and make the code a lot more readable. As the changes are pretty big I will first add a patch and wait for some feedback.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DOSGI-134) Refactoring of TopologyManager
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DOSGI-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider resolved DOSGI-134.
---------------------------------------
Resolution: Fixed
1404960 02.11.2012 14:42:02, by cschneider
DOSGI-134 DOSGI-137 Reordering packages in TopologyManager, fixing bug in checking if an Endpoint is already imported
M /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/Activator.java
D /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/EndpointListenerManager.java
D /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/EndpointListenerNotifier.java
D /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/ExportRepository.java
D /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/ListenerHookImpl.java
D /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/RefManager.java
D /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/RemoteServiceAdminLifeCycleListener.java
D /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/RemoteServiceAdminTracker.java
D /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/ServiceInterestListener.java
D /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/TopologyManager.java
And 24 more
> Refactoring of TopologyManager
> ------------------------------
>
> Key: DOSGI-134
> URL: https://issues.apache.org/jira/browse/DOSGI-134
> Project: CXF Distributed OSGi
> Issue Type: Improvement
> Affects Versions: 1.3.1
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 1.4
>
> Attachments: DOSGI-134-1.patch, DOSGI-134-2.patch, org.apache.cxf.dosgi.topologymanager-after.png
>
>
> Currently the topology manager project contains a lot of cycles between the classes. The code is also rather difficult to understand.
> I have prepared a refactoring to resolve the cycles and make the code a lot more readable. As the changes are pretty big I will first add a patch and wait for some feedback.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DOSGI-134) Refactoring of TopologyManager
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DOSGI-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated DOSGI-134:
--------------------------------------
Attachment: DOSGI-134-2.patch
As a second step I would like to just move the classes into three subpackages:
importer
exporter
rsatracker
The nice thing is that we do not share classes between importer and exporter except for the rsatracker. So this makes it much simpler to understand the code as you can understand exporter and importer individually.
> Refactoring of TopologyManager
> ------------------------------
>
> Key: DOSGI-134
> URL: https://issues.apache.org/jira/browse/DOSGI-134
> Project: CXF Distributed OSGi
> Issue Type: Improvement
> Affects Versions: 1.3.1
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 1.4
>
> Attachments: DOSGI-134-1.patch, DOSGI-134-2.patch, org.apache.cxf.dosgi.topologymanager-after.png
>
>
> Currently the topology manager project contains a lot of cycles between the classes. The code is also rather difficult to understand.
> I have prepared a refactoring to resolve the cycles and make the code a lot more readable. As the changes are pretty big I will first add a patch and wait for some feedback.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DOSGI-134) Refactoring of TopologyManager
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DOSGI-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated DOSGI-134:
--------------------------------------
Attachment: DOSGI-134-1.patch
Added patch for refactoring. I will wait for feedback till 29.10.2012
> Refactoring of TopologyManager
> ------------------------------
>
> Key: DOSGI-134
> URL: https://issues.apache.org/jira/browse/DOSGI-134
> Project: CXF Distributed OSGi
> Issue Type: Bug
> Affects Versions: 1.3.1
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 1.4
>
> Attachments: DOSGI-134-1.patch
>
>
> Currently the topology manager project contains a lot of cycles between the classes. The code is also rather difficult to understand.
> I have prepared a refactoring to resolve the cycles and make the code a lot more readable. As the changes are pretty big I will first add a patch and wait for some feedback.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DOSGI-134) Refactoring of TopologyManager
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DOSGI-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated DOSGI-134:
--------------------------------------
Attachment: org.apache.cxf.dosgi.topologymanager-after.png
> Refactoring of TopologyManager
> ------------------------------
>
> Key: DOSGI-134
> URL: https://issues.apache.org/jira/browse/DOSGI-134
> Project: CXF Distributed OSGi
> Issue Type: Bug
> Affects Versions: 1.3.1
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 1.4
>
> Attachments: DOSGI-134-1.patch, org.apache.cxf.dosgi.topologymanager-after.png
>
>
> Currently the topology manager project contains a lot of cycles between the classes. The code is also rather difficult to understand.
> I have prepared a refactoring to resolve the cycles and make the code a lot more readable. As the changes are pretty big I will first add a patch and wait for some feedback.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DOSGI-134) Refactoring of TopologyManager
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DOSGI-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486891#comment-13486891 ]
Christian Schneider commented on DOSGI-134:
-------------------------------------------
I just applied the patch 1 above:
1403685 30.10.2012 14:10:20, by cschneider
DOSGI-134 Refactoring TopologyManager
M /cxf/dosgi/trunk/dsw/cxf-topology-manager/pom.xml
M /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/Activator.java
D /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/EndpointListenerImpl.java
A /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/EndpointListenerManager.java
A /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/EndpointListenerNotifier.java
A /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/ExportRepository.java
M /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/ListenerHookImpl.java
A /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/RefManager.java
A /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/RemoteServiceAdminLifeCycleListener.java
D /cxf/dosgi/trunk/dsw/cxf-topology-manager/src/main/java/org/apache/cxf/dosgi/topologymanager/RemoteServiceAdminList.java
And 16 more
> Refactoring of TopologyManager
> ------------------------------
>
> Key: DOSGI-134
> URL: https://issues.apache.org/jira/browse/DOSGI-134
> Project: CXF Distributed OSGi
> Issue Type: Improvement
> Affects Versions: 1.3.1
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 1.4
>
> Attachments: DOSGI-134-1.patch, org.apache.cxf.dosgi.topologymanager-after.png
>
>
> Currently the topology manager project contains a lot of cycles between the classes. The code is also rather difficult to understand.
> I have prepared a refactoring to resolve the cycles and make the code a lot more readable. As the changes are pretty big I will first add a patch and wait for some feedback.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DOSGI-134) Refactoring of TopologyManager
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DOSGI-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated DOSGI-134:
--------------------------------------
Issue Type: Improvement (was: Bug)
> Refactoring of TopologyManager
> ------------------------------
>
> Key: DOSGI-134
> URL: https://issues.apache.org/jira/browse/DOSGI-134
> Project: CXF Distributed OSGi
> Issue Type: Improvement
> Affects Versions: 1.3.1
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 1.4
>
> Attachments: DOSGI-134-1.patch, org.apache.cxf.dosgi.topologymanager-after.png
>
>
> Currently the topology manager project contains a lot of cycles between the classes. The code is also rather difficult to understand.
> I have prepared a refactoring to resolve the cycles and make the code a lot more readable. As the changes are pretty big I will first add a patch and wait for some feedback.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira