[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34794: [SPARK-37532][CORE] Limit the length of RDD name

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #34794:
URL: https://github.com/apache/spark/pull/34794#discussion_r762472083



##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -2267,4 +2267,13 @@ package object config {
       .version("3.3.0")
       .intConf
       .createWithDefault(5)
+
+  private[spark]val MAX_RDD_NAME_LENGTH = ConfigBuilder("spark.rdd.nameMaxLength")
+    .internal()
+    .doc("Maximum number of characters for RDD name. For example, some of the HadoopRDD API will" +
+      "use the path parameter as RDD name which could be extremely long")
+    .version("3.3.0")
+    .intConf
+    .checkValue(_ > 3, "This value must be bigger than 3.")
+    .createWithDefault(256)

Review comment:
       @yaooqinn .
   - This looks like a breaking change for the downstream expecting the same names they set.
   - If we need this configuration, the default value should be `Int.MaxValue` at least too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org