You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by anmolnar <gi...@git.apache.org> on 2017/12/12 12:35:04 UTC

[GitHub] zookeeper pull request #429: ZOOKEEPER-2952. Upgrade third party libs: netty...

GitHub user anmolnar opened a pull request:

    https://github.com/apache/zookeeper/pull/429

    ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-2952

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/429.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #429
    
----
commit 949ada4ae0ad87388269bcc728affffcce325f04
Author: Andor Molnar <an...@cloudera.com>
Date:   2017-12-12T11:04:48Z

    ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j

----


---

[GitHub] zookeeper issue #429: ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j

Posted by anmolnar <gi...@git.apache.org>.

Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/429
  
    @phunt I've updated the slf4j license.


---

[GitHub] zookeeper pull request #429: ZOOKEEPER-2952. Upgrade third party libs: netty...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zookeeper/pull/429


---

[GitHub] zookeeper issue #429: ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j

Posted by phunt <gi...@git.apache.org>.

Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/429
  
    @anmolnar looks like a good change to me - however src/java/lib/ needs to be updated to reflect this change. Also the patch doesn't apply to branch3.4, please submit a separate PR for that.


---

[GitHub] zookeeper issue #429: ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j

Posted by phunt <gi...@git.apache.org>.

Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/429
  
    lgtm +1, thanks @anmolnar 


---