You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by rpelisse <gi...@git.apache.org> on 2018/09/27 09:43:19 UTC
[GitHub] activemq-artemis pull request #2336: ARTEMIS-1874 fix NPE setting object pro...
GitHub user rpelisse opened a pull request:
https://github.com/apache/activemq-artemis/pull/2336
ARTEMIS-1874 fix NPE setting object property
Upstream Issue: https://issues.apache.org/jira/browse/ARTEMIS-1874
Issue: https://issues.jboss.org/browse/JBEAP-15516
No upstream PR required, changes already in master
This is just a backport of the fix into the 1.x branch. I've setup the PR just to make the backport easy for devs, if you prefer to cherry-pick this fix later on yourself, feel free to simply close this PR! (or ask me to do it).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rpelisse/activemq-artemis JBEAP-15516_1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2336.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2336
----
commit 02c201e8e15967f8512d519e1b6bf0a16bb5a28b
Author: Justin Bertram <jb...@...>
Date: 2018-05-21T14:55:15Z
ARTEMIS-1874 fix NPE setting object property
----
---
[GitHub] activemq-artemis pull request #2336: ARTEMIS-1874 fix NPE setting object pro...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2336
---
[GitHub] activemq-artemis issue #2336: ARTEMIS-1874 fix NPE setting object property
Posted by rpelisse <gi...@git.apache.org>.
Github user rpelisse commented on the issue:
https://github.com/apache/activemq-artemis/pull/2336
But of course! Just done so (and thanks for the tip, never noticed this -x option, it's pretty neat).
---
[GitHub] activemq-artemis issue #2336: ARTEMIS-1874 fix NPE setting object property
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2336
@rpelisse we have started using cherry-pick -x on the other branches to make it easier to find correlations between the branches.
---
[GitHub] activemq-artemis issue #2336: ARTEMIS-1874 fix NPE setting object property
Posted by rpelisse <gi...@git.apache.org>.
Github user rpelisse commented on the issue:
https://github.com/apache/activemq-artemis/pull/2336
The CI run failed due to some "connection refused". It looks unrelated to my changes, but please let me know if you think otherwise!
---
[GitHub] activemq-artemis issue #2336: ARTEMIS-1874 fix NPE setting object property
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2336
@rpelisse what is the commit ID upstream? can you use cherry-pick -x (or amend the commit with the full hash?)
example from another commit:
```
commit 19998d310f143ad5370683db42c63f64b43ee338
Author: Justin Bertram <jb...@apache.org>
Date: Wed Sep 26 14:27:14 2018 -0500
ARTEMIS-2098 potential NPE when decoding protocol
(cherry picked from commit c72bf53cb178d2d9d310f3f369c0cbdb22e6f50c)
```
---