You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/11 13:09:43 UTC

[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example

mbalassi commented on code in PR #308:
URL: https://github.com/apache/flink-kubernetes-operator/pull/308#discussion_r917909509


##########
docs/content/docs/custom-resource/pod-template.md:
##########
@@ -100,6 +100,66 @@ spec:
     parallelism: 2
 ```
 
+We also provide a way to obtain the jar package remotely, which can avoid you repeating the packaging image every time
+```yaml
+apiVersion: flink.apache.org/v1beta1
+kind: FlinkDeployment
+metadata:
+  namespace: default
+  name: pod-template-example
+spec:
+  image: flink:1.15
+  flinkVersion: v1_15

Review Comment:
   please add `spec.serviceAccount: flink`



##########
docs/content/docs/custom-resource/pod-template.md:
##########
@@ -100,6 +100,66 @@ spec:
     parallelism: 2
 ```
 
+We also provide a way to obtain the jar package remotely, which can avoid you repeating the packaging image every time

Review Comment:
   nit: "package remotely, which can avoid you repeating the packaging image every time" -> "package remotely to avoid repeating the image packaging on each iteration."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org