[GitHub] kiszk commented on a change in pull request #23815: [SPARK-26908][SQL] Fix DateTimeUtils.toMillis and millisToDays

[GitBox <gi...@apache.org>]

kiszk commented on a change in pull request #23815: [SPARK-26908][SQL] Fix DateTimeUtils.toMillis and millisToDays
URL: https://github.com/apache/spark/pull/23815#discussion_r257543056
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
 ##########
 @@ -85,7 +85,7 @@ object DateTimeUtils {
     // SPARK-6785: use Math.floor so negative number of days (dates before 1970)
 
 Review comment:
   nit: Do we need to update this comment since this PR will replace `floor` with `floorDiv`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org