You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by hl...@apache.org on 2012/12/16 02:17:33 UTC

[49/50] git commit: Fix test broken by use of @MixinAfter on RenderNotification mixin

Fix test broken by use of @MixinAfter on RenderNotification mixin


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/4da3d9bf
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/4da3d9bf
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/4da3d9bf

Branch: refs/heads/master
Commit: 4da3d9bfe64591cad399da76a85338f8178ba6dc
Parents: 8c95676
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Thu Nov 29 17:28:46 2012 -0800
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Thu Nov 29 17:28:46 2012 -0800

----------------------------------------------------------------------
 54_RELEASE_NOTES.txt                               |    8 +++++++-
 .../src/test/app1/RenderNotificationDemo.tml       |    6 +++---
 2 files changed, 10 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4da3d9bf/54_RELEASE_NOTES.txt
----------------------------------------------------------------------
diff --git a/54_RELEASE_NOTES.txt b/54_RELEASE_NOTES.txt
index 785c1b1..cd773b2 100644
--- a/54_RELEASE_NOTES.txt
+++ b/54_RELEASE_NOTES.txt
@@ -152,4 +152,10 @@ The selected property is now type `Collection`, not specifically type `List`. It
 
 The Autocomplete mixin has been rewritten to use Bootstrap; this implies it will also force jQuery onto the page,
 to support the Bootstrap JavaScript library. In addition, Bootstrap's typeahead component does not support multiple
-tokens, so this behavior has been removed.
\ No newline at end of file
+tokens, so this behavior has been removed.
+
+## RenderNotification Mixin
+
+The timing of this mixin has changed, it now has the @MixinAfter annotation, so it triggers its events *after*
+the component to which it attaches has executed its @BeginRender phase, and *before* the component executes
+its @AfterRender phase.
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4da3d9bf/tapestry-core/src/test/app1/RenderNotificationDemo.tml
----------------------------------------------------------------------
diff --git a/tapestry-core/src/test/app1/RenderNotificationDemo.tml b/tapestry-core/src/test/app1/RenderNotificationDemo.tml
index 7f10fa6..249b3d4 100644
--- a/tapestry-core/src/test/app1/RenderNotificationDemo.tml
+++ b/tapestry-core/src/test/app1/RenderNotificationDemo.tml
@@ -1,9 +1,9 @@
-<html t:type="Border" xmlns:t="http://tapestry.apache.org/schema/tapestry_5_0_0.xsd">
+<html t:type="Border" xmlns:t="http://tapestry.apache.org/schema/tapestry_5_3.xsd">
 
   <h1>RenderNotification Mixin Demo</h1>
 
-  <ul id="list">
-    <li t:type="any" t:id="item" t:mixins="rendernotification">item body in template</li>
+  <ul id="list" t:type="any" t:id="item" t:mixins="rendernotification">
+    <li>item body in template</li>
   </ul>
 
 </html>