[GitHub] [lucene] romseygeek opened a new pull request #110: LUCENE-9940: DisjunctionMaxQuery shouldn't depend on disjunct order for equals checks

[GitBox <gi...@apache.org>]

romseygeek opened a new pull request #110:
URL: https://github.com/apache/lucene/pull/110


   DisjunctionMaxQuery stores its disjuncts in a `Query[]`, and uses
   `Arrays.equals()` for comparisons in its `equals()` implementation.
   This means that the order in which disjuncts are added to the query
   matters for equality checks.
   
   This commit changes DMQ to instead store its disjuncts in a Multiset,
   meaning that ordering no longer matters.  The `getDisjuncts()`
   method now returns a `Collection<Query>` rather than a `List`, and
   some tests are changed to use query equality checks rather than 
   iterating over disjuncts and expecting a particular order.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] romseygeek merged pull request #110: LUCENE-9940: DisjunctionMaxQuery shouldn't depend on disjunct order for equals checks

[GitBox <gi...@apache.org>]

romseygeek merged pull request #110:
URL: https://github.com/apache/lucene/pull/110


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org