You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "the-last (via GitHub)" <gi...@apache.org> on 2023/05/17 15:15:53 UTC
[GitHub] [superset] the-last opened a new pull request, #24098: fix: from other dashboard 'filters' will confict 'requiredFirst' option…
the-last opened a new pull request, #24098:
URL: https://github.com/apache/superset/pull/24098
Describe:
Jumping from the Kanban link to another Kanban with default filtering conditions will result in a dead cycle
fix(dashboard): load charts correctly
### TESTING INSTRUCTIONS
#### How to reproduce the bug
1, Add clickable links to the charts in the dashboard, such as [id]
2, Create a Kanban using the same chart as the first step
3, Create a new filter condition on the created dashboard, with mandatory configuration and the first item selected by default, such as [id]
4, Open the previous kanban and click on the [id] link in the icon, Then there will be a dead cycle
### ADDITIONAL INFORMATION
- [x] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: from other dashboard 'filters' will confict 'requiredFirst' option… [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24098:
URL: https://github.com/apache/superset/pull/24098#issuecomment-2299301102
What exactly do you mean by "create a kanban"? There's not a kanban board plugin in Superset, so I'm not quite sure what you mean. Maybe a video or screenshots would help here?
Closing and re-opening to kick-start CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: from other dashboard 'filters' will confict 'requiredFirst' option… [superset]
Posted by "Vitor-Avila (via GitHub)" <gi...@apache.org>.
Vitor-Avila commented on PR #24098:
URL: https://github.com/apache/superset/pull/24098#issuecomment-2821842646
I agree with @rusackas here -- happy to do some manual testing if needed, but need some additional context on the bug. A video demonstrating the issue previously is highly appreciated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: from other dashboard 'filters' will confict 'requiredFirst' option… [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24098:
URL: https://github.com/apache/superset/pull/24098#issuecomment-3882992657
Closing due to contributor inactivity for several months. Feel free to reopen if/when warranted, and thank you for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: from other dashboard 'filters' will confict 'requiredFirst' option… [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24098:
URL: https://github.com/apache/superset/pull/24098#issuecomment-3180976124
Still missing context here, and there's a conflict in need of resolution. Setting to draft for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: from other dashboard 'filters' will confict 'requiredFirst' option… [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #24098: fix: from other dashboard 'filters' will confict 'requiredFirst' option…
URL: https://github.com/apache/superset/pull/24098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: from other dashboard 'filters' will confict 'requiredFirst' option… [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #24098: fix: from other dashboard 'filters' will confict 'requiredFirst' option…
URL: https://github.com/apache/superset/pull/24098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: from other dashboard 'filters' will confict 'requiredFirst' option… [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24098:
URL: https://github.com/apache/superset/pull/24098#issuecomment-2299349390
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24098?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 69.88%. Comparing base [(`357745f`)](https://app.codecov.io/gh/apache/superset/commit/357745f418d3eb42fececd6fd7d4a59337709a1d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`823df18`)](https://app.codecov.io/gh/apache/superset/commit/823df18ba58de64d79765f4fe4757133885aca9c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 2323 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #24098 +/- ##
==========================================
+ Coverage 68.31% 69.88% +1.57%
==========================================
Files 1951 1963 +12
Lines 75385 77589 +2204
Branches 8185 9039 +854
==========================================
+ Hits 51496 54220 +2724
+ Misses 21786 21151 -635
- Partials 2103 2218 +115
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/24098/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/24098/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.39% <100.00%> (+3.69%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/24098?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org