[GitHub] [dolphinscheduler] Radeity commented on a diff in pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

[GitBox <gi...@apache.org>]

Radeity commented on code in PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#discussion_r1055092343


##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -684,6 +685,9 @@ private void initTaskQueue() {
         if (processInstance.isComplementData() && complementListDate.size() == 0) {
             Map<String, String> cmdParam = JSONUtils.toMap(processInstance.getCommandParam());
             if (cmdParam != null && cmdParam.containsKey(CMDPARAM_COMPLEMENT_DATA_START_DATE)) {

Review Comment:
   > This is not just a complement. There should be a similar problem when you directly click Start
   
   This part fixes that cmd param can overwrite global param when executing complement, change in ProcessService fix bug when directly click Start.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org