You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "dombizita (via GitHub)" <gi...@apache.org> on 2023/02/24 10:20:40 UTC

[GitHub] [ozone] dombizita opened a new pull request, #4310: HDDS-7979. Replace import from shaded Guava

dombizita opened a new pull request, #4310:
URL: https://github.com/apache/ozone/pull/4310

   ## What changes were proposed in this pull request?
   
   Changed `VisibleForTesting` import to `com.google.common.annotations.VisibleForTesting`.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-7979
   
   ## How was this patch tested?
   
   Built the project successfully, CI on my fork: https://github.com/dombizita/ozone/actions/runs/4258016809
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] Galsza commented on pull request #4310: HDDS-7979. Replace import from shaded Guava

Posted by "Galsza (via GitHub)" <gi...@apache.org>.
Galsza commented on PR #4310:
URL: https://github.com/apache/ozone/pull/4310#issuecomment-1443536776

   LGTM!
   
   RDBStore and RatisPipelineProvider are also using this import, could they cause a problem later? Either update them, or please create an issue for master later to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai commented on pull request #4310: HDDS-7979. Replace import from shaded Guava

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4310:
URL: https://github.com/apache/ozone/pull/4310#issuecomment-1443749111

   Thanks @dombizita for the fix, @Galsza for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai merged pull request #4310: HDDS-7979. Replace import from shaded Guava

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4310:
URL: https://github.com/apache/ozone/pull/4310


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai commented on pull request #4310: HDDS-7979. Replace import from shaded Guava

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4310:
URL: https://github.com/apache/ozone/pull/4310#issuecomment-1443665384

   > RDBStore and RatisPipelineProvider are also using this import, could they cause a problem later? Either update them, or please create an issue for master later to fix it.
   
   Thanks @Galsza for pointing it out, I haven't noticed those earlier.  Created HDDS-8026 for items on `master` branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org