You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/01 17:54:44 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #19493: chore: Removes hard-coded colors from legacy-plugin-chart-sankey
michael-s-molina opened a new pull request #19493:
URL: https://github.com/apache/superset/pull/19493
### SUMMARY
Removes hard-coded colors from `legacy-plugin-chart-sankey`.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1153" alt="Screen Shot 2022-04-01 at 2 47 05 PM" src="https://user-images.githubusercontent.com/70410625/161316591-551b4ebe-8ceb-4dba-b2ff-cdbaee43f992.png">
<img width="1150" alt="Screen Shot 2022-04-01 at 2 51 41 PM" src="https://user-images.githubusercontent.com/70410625/161316598-a3340611-b6ae-45f4-8f00-619160604730.png">
### TESTING INSTRUCTIONS
Check that the plugin is very similar to the previous version. We may have color, font, and opacity differences due to theme adjustments.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19493: chore: Removes hard-coded colors from legacy-plugin-chart-sankey
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19493:
URL: https://github.com/apache/superset/pull/19493#issuecomment-1086267608
# [Codecov](https://codecov.io/gh/apache/superset/pull/19493?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19493](https://codecov.io/gh/apache/superset/pull/19493?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e39a014) into [master](https://codecov.io/gh/apache/superset/commit/5fed10dae2723bbcab46e54c9eb6ca55272c34d3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5fed10d) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head e39a014 differs from pull request most recent head 3c5b17e. Consider uploading reports for the commit 3c5b17e to get more accurate results
```diff
@@ Coverage Diff @@
## master #19493 +/- ##
=======================================
Coverage 66.58% 66.58%
=======================================
Files 1677 1677
Lines 64238 64237 -1
Branches 6538 6538
=======================================
Hits 42773 42773
+ Misses 19766 19765 -1
Partials 1699 1699
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.32% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx](https://codecov.io/gh/apache/superset/pull/19493/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXNhbmtleS9zcmMvUmVhY3RTYW5rZXkuanN4) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19493?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19493?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5fed10d...3c5b17e](https://codecov.io/gh/apache/superset/pull/19493?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org