You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/12 22:51:38 UTC
Review Request 55472: Moved `Slave` definitions out-of-line to
master.cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55472/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-6619
https://issues.apache.org/jira/browse/MESOS-6619
Repository: mesos
Description
-------
Previously, one of the `Slave` member functions was defined out-of-line,
but the rest were defined inline; make them all defined out-of-line for
consistency, and also to allow the function implementations to access
members of `Master` in the future.
Diffs
-----
src/master/master.hpp 368ee1d5e97784fa54e0f141906405ee8f104317
src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040
Diff: https://reviews.apache.org/r/55472/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 55472: Moved `Slave` definitions out-of-line to
master.cpp.
Posted by Neil Conway <ne...@gmail.com>.
> On Jan. 19, 2017, 4:48 p.m., Vinod Kone wrote:
> > src/master/master.cpp, lines 8874-8876
> > <https://reviews.apache.org/r/55472/diff/2/?file=1607807#file1607807line8874>
> >
> > does this not fit in one line?
> >
> > i know in the headers we sometimes put them on different lines for consistency with closeby methods, but we don't do that in cpp files.
This does not fit on one line (91 characters wide). I put it on two lines instead of three.
> On Jan. 19, 2017, 4:48 p.m., Vinod Kone wrote:
> > src/master/master.cpp, lines 8883-8885
> > <https://reviews.apache.org/r/55472/diff/2/?file=1607807#file1607807line8883>
> >
> > one line?
Does not fit on one line (89 chars), but I but it on two lines instead of three.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55472/#review162306
-----------------------------------------------------------
On Jan. 18, 2017, 5 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55472/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 5 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6619
> https://issues.apache.org/jira/browse/MESOS-6619
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, one of the `Slave` member functions was defined out-of-line,
> but the rest were defined inline; make them all defined out-of-line for
> consistency, and also to allow the function implementations to access
> members of `Master` in the future.
>
>
> Diffs
> -----
>
> src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b
> src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba
>
> Diff: https://reviews.apache.org/r/55472/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 55472: Moved `Slave` definitions out-of-line to
master.cpp.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55472/#review162306
-----------------------------------------------------------
src/master/master.cpp (lines 8871 - 8873)
<https://reviews.apache.org/r/55472/#comment233638>
does this not fit in one line?
i know in the headers we sometimes put them on different lines for consistency with closeby methods, but we don't do that in cpp files.
src/master/master.cpp (lines 8880 - 8882)
<https://reviews.apache.org/r/55472/#comment233639>
one line?
src/master/master.cpp (line 8891)
<https://reviews.apache.org/r/55472/#comment233637>
2 lines.
- Vinod Kone
On Jan. 18, 2017, 5 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55472/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 5 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6619
> https://issues.apache.org/jira/browse/MESOS-6619
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, one of the `Slave` member functions was defined out-of-line,
> but the rest were defined inline; make them all defined out-of-line for
> consistency, and also to allow the function implementations to access
> members of `Master` in the future.
>
>
> Diffs
> -----
>
> src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b
> src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba
>
> Diff: https://reviews.apache.org/r/55472/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 55472: Moved `Slave` definitions out-of-line to
master.cpp.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55472/#review162305
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 18, 2017, 5 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55472/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 5 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6619
> https://issues.apache.org/jira/browse/MESOS-6619
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, one of the `Slave` member functions was defined out-of-line,
> but the rest were defined inline; make them all defined out-of-line for
> consistency, and also to allow the function implementations to access
> members of `Master` in the future.
>
>
> Diffs
> -----
>
> src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b
> src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba
>
> Diff: https://reviews.apache.org/r/55472/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 55472: Moved `Slave` definitions out-of-line to
master.cpp.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55472/
-----------------------------------------------------------
(Updated Jan. 19, 2017, 4:57 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Whitespace fixes.
Bugs: MESOS-6619
https://issues.apache.org/jira/browse/MESOS-6619
Repository: mesos
Description
-------
Previously, one of the `Slave` member functions was defined out-of-line,
but the rest were defined inline; make them all defined out-of-line for
consistency, and also to allow the function implementations to access
members of `Master` in the future.
Diffs (updated)
-----
src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b
src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba
Diff: https://reviews.apache.org/r/55472/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 55472: Moved `Slave` definitions out-of-line to
master.cpp.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55472/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 5 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Rebase.
Bugs: MESOS-6619
https://issues.apache.org/jira/browse/MESOS-6619
Repository: mesos
Description
-------
Previously, one of the `Slave` member functions was defined out-of-line,
but the rest were defined inline; make them all defined out-of-line for
consistency, and also to allow the function implementations to access
members of `Master` in the future.
Diffs (updated)
-----
src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b
src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba
Diff: https://reviews.apache.org/r/55472/diff/
Testing
-------
`make check`
Thanks,
Neil Conway