You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/07 09:31:58 UTC

[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request #23: Set default version in release script

wu-sheng commented on a change in pull request #23: Set default version in release script
URL: https://github.com/apache/skywalking-cli/pull/23#discussion_r355111578
 
 

 ##########
 File path: Makefile
 ##########
 @@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-VERSION ?= latest
+VERSION ?= 0.1.0
 
 Review comment:
   I think we should set it to `0.2.0-latest`? And with a real release script to override this?
   
   In traditional, we should follow the pattern, version + snapshot/latest/commit id as dev version. 0.1.0, 0.2.0 should only work for release, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services