You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Bernd Eckenfels <ec...@zusammenkunft.net> on 2014/02/14 20:07:08 UTC
[VFS] trailing space cleanup (was: svn commit: r1568471 -
/commons/proper/vfs/trunk/pom.xml)
Hello,
quick question, while doing my first commit I noticed that Eclipse
wanted to clean up a number of trailing blanks in that POM file. I
decided to not commit those unrelated changes.
What is your preference - should I do an additional cleanup commit,
leave the blanks untouched or accept a few additional line changes in
real commit?
BTW: thanks everybody for your warm welcome. My ecki-at-apache.org
account/alias so I am more or less operational (my PGP Key will come
later).
Bernd
Am Fri,
14 Feb 2014 19:03:13 -0000 schrieb ecki@apache.org:
> Author: ecki
> Date: Fri Feb 14 19:03:12 2014
> New Revision: 1568471
>
> URL: http://svn.apache.org/r1568471
> Log:
> Add ecki to the developers list. First commit!
>
> Modified:
> commons/proper/vfs/trunk/pom.xml
>
> Modified: commons/proper/vfs/trunk/pom.xml
> URL:
> http://svn.apache.org/viewvc/commons/proper/vfs/trunk/pom.xml?rev=1568471&r1=1568470&r2=1568471&view=diff
> ==============================================================================
> --- commons/proper/vfs/trunk/pom.xml (original) +++
> commons/proper/vfs/trunk/pom.xml Fri Feb 14 19:03:12 2014 @@ -102,6
> +102,13 @@ <url>http://www.garygregory.com</url>
> <timezone>-5</timezone>
> </developer>
> + <developer>
> + <name>Bernd Eckenfels</name>
> + <id>ecki</id>
> + <email>ecki -at- apache.org</email>
> + <url>http://bernd.eckenfels.net</url>
> + <timezone>+1</timezone>
> + </developer>
> </developers>
>
> <contributors>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VFS] trailing space cleanup (was: svn commit: r1568471 - /commons/proper/vfs/trunk/pom.xml)
Posted by Paul Benedict <pb...@apache.org>.
Because eyes are always on the code (thank you very much commit mailing
list), people want to know the real differences between the files. It's
extremely difficult to know what a developer did if a commit to fix
something also includes cosmetic fixes. Separate the two out always and let
the commit log show as such.
On Fri, Feb 14, 2014 at 1:16 PM, Gary Gregory <ga...@gmail.com>wrote:
> I think you have too look at it from the POV of people who are going to
> look at the commit logs and emails to see the diffs.
>
> For me, I think it makes sense, to separate the meat of an implementation
> or fix from cosmetic changes. Sometimes it can be too much of a pain to
> separate the two, so this is a guideline not a strict rule. I like Eclipse
> and use its Clean Up feature all the time. I usually try to be verbose in
> the commit comments to help any reviewers out there. This at least makes it
> clear as to what my intention was with the commit.
>
> Gary
>
>
> On Fri, Feb 14, 2014 at 2:07 PM, Bernd Eckenfels <ecki@zusammenkunft.net
> >wrote:
>
> > Hello,
> >
> > quick question, while doing my first commit I noticed that Eclipse
> > wanted to clean up a number of trailing blanks in that POM file. I
> > decided to not commit those unrelated changes.
> >
> > What is your preference - should I do an additional cleanup commit,
> > leave the blanks untouched or accept a few additional line changes in
> > real commit?
> >
> > BTW: thanks everybody for your warm welcome. My ecki-at-apache.org
> > account/alias so I am more or less operational (my PGP Key will come
> > later).
> >
> > Bernd
> >
> > Am Fri,
> > 14 Feb 2014 19:03:13 -0000 schrieb ecki@apache.org:
> >
> > > Author: ecki
> > > Date: Fri Feb 14 19:03:12 2014
> > > New Revision: 1568471
> > >
> > > URL: http://svn.apache.org/r1568471
> > > Log:
> > > Add ecki to the developers list. First commit!
> > >
> > > Modified:
> > > commons/proper/vfs/trunk/pom.xml
> > >
> > > Modified: commons/proper/vfs/trunk/pom.xml
> > > URL:
> > >
> >
> http://svn.apache.org/viewvc/commons/proper/vfs/trunk/pom.xml?rev=1568471&r1=1568470&r2=1568471&view=diff
> > >
> >
> ==============================================================================
> > > --- commons/proper/vfs/trunk/pom.xml (original) +++
> > > commons/proper/vfs/trunk/pom.xml Fri Feb 14 19:03:12 2014 @@ -102,6
> > > +102,13 @@ <url>http://www.garygregory.com</url>
> > > <timezone>-5</timezone>
> > > </developer>
> > > + <developer>
> > > + <name>Bernd Eckenfels</name>
> > > + <id>ecki</id>
> > > + <email>ecki -at- apache.org</email>
> > > + <url>http://bernd.eckenfels.net</url>
> > > + <timezone>+1</timezone>
> > > + </developer>
> > > </developers>
> > >
> > > <contributors>
> > >
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<
> http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
Cheers,
Paul
Re: [VFS] trailing space cleanup (was: svn commit: r1568471 - /commons/proper/vfs/trunk/pom.xml)
Posted by Gary Gregory <ga...@gmail.com>.
I think you have too look at it from the POV of people who are going to
look at the commit logs and emails to see the diffs.
For me, I think it makes sense, to separate the meat of an implementation
or fix from cosmetic changes. Sometimes it can be too much of a pain to
separate the two, so this is a guideline not a strict rule. I like Eclipse
and use its Clean Up feature all the time. I usually try to be verbose in
the commit comments to help any reviewers out there. This at least makes it
clear as to what my intention was with the commit.
Gary
On Fri, Feb 14, 2014 at 2:07 PM, Bernd Eckenfels <ec...@zusammenkunft.net>wrote:
> Hello,
>
> quick question, while doing my first commit I noticed that Eclipse
> wanted to clean up a number of trailing blanks in that POM file. I
> decided to not commit those unrelated changes.
>
> What is your preference - should I do an additional cleanup commit,
> leave the blanks untouched or accept a few additional line changes in
> real commit?
>
> BTW: thanks everybody for your warm welcome. My ecki-at-apache.org
> account/alias so I am more or less operational (my PGP Key will come
> later).
>
> Bernd
>
> Am Fri,
> 14 Feb 2014 19:03:13 -0000 schrieb ecki@apache.org:
>
> > Author: ecki
> > Date: Fri Feb 14 19:03:12 2014
> > New Revision: 1568471
> >
> > URL: http://svn.apache.org/r1568471
> > Log:
> > Add ecki to the developers list. First commit!
> >
> > Modified:
> > commons/proper/vfs/trunk/pom.xml
> >
> > Modified: commons/proper/vfs/trunk/pom.xml
> > URL:
> >
> http://svn.apache.org/viewvc/commons/proper/vfs/trunk/pom.xml?rev=1568471&r1=1568470&r2=1568471&view=diff
> >
> ==============================================================================
> > --- commons/proper/vfs/trunk/pom.xml (original) +++
> > commons/proper/vfs/trunk/pom.xml Fri Feb 14 19:03:12 2014 @@ -102,6
> > +102,13 @@ <url>http://www.garygregory.com</url>
> > <timezone>-5</timezone>
> > </developer>
> > + <developer>
> > + <name>Bernd Eckenfels</name>
> > + <id>ecki</id>
> > + <email>ecki -at- apache.org</email>
> > + <url>http://bernd.eckenfels.net</url>
> > + <timezone>+1</timezone>
> > + </developer>
> > </developers>
> >
> > <contributors>
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory