[GitHub] himanshug edited a comment on issue #6377: Use NodeType enum instead of Strings

[GitBox <gi...@apache.org>]

himanshug edited a comment on issue #6377: Use NodeType enum instead of Strings
URL: https://github.com/apache/incubator-druid/pull/6377#issuecomment-429107498
 
 
   my two cents...
   I certainly don't expect all PRs to go through real cluster testing except the ones that change cluster coordination or other things that are hard to unit test etc.
   Release baking process is great but doesn't have to be a substitute for testing our own code. Also, by that time a lot of PRs pile on top of each other and maybe harder to pinpoint exactly which PR caused the issue. So, it is again nice to do some testing upfront and not wait for release being cut.
   
   Personally, I feel more confident with the work when it is tested. Code reviews catch some bugs but testing the change is always great when possible :) .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org