[GitHub] [pulsar-client-cpp] shibd commented on a diff in pull request #156: [fix] Fix log for connection disconnected expectedly

[GitBox <gi...@apache.org>]

shibd commented on code in PR #156:
URL: https://github.com/apache/pulsar-client-cpp/pull/156#discussion_r1057226702


##########
lib/ClientConnection.cc:
##########
@@ -1596,7 +1596,11 @@ void ClientConnection::close(Result result) {
     }
 
     lock.unlock();
-    LOG_INFO(cnxString_ << "Connection closed with " << result);
+    if (result != ResultDisconnected) {
+        LOG_ERROR(cnxString_ << "Connection closed with " << result);

Review Comment:
   When the result is `ResultRetryable`, is there no need to print the error log here?
   
   BTW: I think just print the info level log here because calling close is the expected behavior of the code. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org