You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/12/03 06:09:00 UTC
[jira] [Commented] (IMPALA-8990)
TestAdmissionController.test_set_request_pool seems flaky
[ https://issues.apache.org/jira/browse/IMPALA-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242937#comment-17242937 ]
ASF subversion and git services commented on IMPALA-8990:
---------------------------------------------------------
Commit a34bb2ad1128a6f401ffd457db8d8fd8e1270374 in impala's branch refs/heads/master from Bikramjeet Vig
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a34bb2a ]
IMPALA-8990: Fix flakiness in test_set_request_pool
This patch fixes flakiness in test_set_request_pool where one of the
test cases expects a query to already be accounted for in a resource
pool but sometimes gets into a state where it runs before the
previous query passes admission control. This fixes the issue by
waiting for the previous query to clear admission control before
attempting to run the aforementioned failing query.
Testing:
- Ran test locally in a loop for an hour to flush out flakiness.
Change-Id: Ife06509e936443579ca60780013ce01352c8932e
Reviewed-on: http://gerrit.cloudera.org:8080/16749
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> TestAdmissionController.test_set_request_pool seems flaky
> ---------------------------------------------------------
>
> Key: IMPALA-8990
> URL: https://issues.apache.org/jira/browse/IMPALA-8990
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 3.4.0
> Reporter: Michael Ho
> Assignee: Bikramjeet Vig
> Priority: Critical
> Labels: flaky
>
> Expected query error didn't occur. Happened once so far. [~bikram], can you please take a look ?
> {noformat}
> Error Message
> AssertionError: Query should return error assert False
> Stacktrace
> hs2/hs2_test_suite.py:63: in add_session
> lambda: fn(self))
> hs2/hs2_test_suite.py:44: in add_session_helper
> fn()
> hs2/hs2_test_suite.py:63: in <lambda>
> lambda: fn(self))
> custom_cluster/test_admission_controller.py:312: in test_set_request_pool
> self.__check_pool_rejected(client, 'root.queueA', "exceeded timeout")
> custom_cluster/test_admission_controller.py:195: in __check_pool_rejected
> assert False, "Query should return error"
> E AssertionError: Query should return error
> E assert False
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org