You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "Samunroyu (via GitHub)" <gi...@apache.org> on 2023/11/29 12:51:17 UTC
[PR] feat(replica): parameterize dsn::utils::FileDataType in the replica_xxx_info [incubator-pegasus]
Samunroyu opened a new pull request, #1703:
URL: https://github.com/apache/incubator-pegasus/pull/1703
### What problem does this PR solve? <!--add issue link with summary if exists-->
The class replica_kms_info of key manager need write with Nonsensitve. Parameterizing dsn::utils::FileDataType with the relative function.
### What is changed and how does it work?
### Checklist <!--REMOVE the items that are not applicable-->
##### Tests <!-- At least one of them must be included. -->
- Unit test
##### Code changes
src/replica/replica.h
src/replica/replica.cpp
src/replica/replica_disk_migrator.h
src/replica/replica_disk_migrator.cpp
src/replica/replication_app_base.h
src/replica/replication_app_base.cpp
src/replica/replica_stub.h
src/replica/replica_stub.cpp
src/replica/test/replica_test.cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] feat(replica): parameterize dsn::utils::FileDataType [incubator-pegasus]
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #1703:
URL: https://github.com/apache/incubator-pegasus/pull/1703#discussion_r1413637957
##########
src/replica/replication_app_base.h:
##########
@@ -71,13 +72,14 @@ class replica_init_info
public:
replica_init_info() { memset((void *)this, 0, sizeof(*this)); }
- error_code load(const std::string &dir) WARN_UNUSED_RESULT;
- error_code store(const std::string &dir);
+ error_code load(const std::string &dir,
Review Comment:
I don't think it's neccessary to changes these functions of `replica_init_info` or `replica_app_info`. You only need to refactor write_blob_to_file, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] feat(replica): add FileDataType as the parameter [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan merged PR #1703:
URL: https://github.com/apache/incubator-pegasus/pull/1703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org