[GitHub] [zeppelin] cuspymd commented on a change in pull request #4120: [ZEPPELIN-5374] Don't update paragraph config when latest checkpoint of flink is unchanged

[GitBox <gi...@apache.org>]

cuspymd commented on a change in pull request #4120:
URL: https://github.com/apache/zeppelin/pull/4120#discussion_r634442983



##########
File path: flink/interpreter/src/main/java/org/apache/zeppelin/flink/JobManager.java
##########
@@ -254,11 +255,12 @@ public void run() {
               if (completedObject.has("external_path")) {
                 String checkpointPath = completedObject.getString("external_path");
                 LOGGER.debug("Latest checkpoint path: {}", checkpointPath);
-                if (!StringUtils.isBlank(checkpointPath)) {
+                if (!StringUtils.isBlank(checkpointPath) && !checkpointPath.equals(latestCheckpointPath)) {

Review comment:
       It seems that using the operator "not (!)" only once is good for readability.
   ```suggestion
                   if (!(StringUtils.isBlank(checkpointPath) || checkpointPath.equals(latestCheckpointPath))) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org