You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/25 10:45:40 UTC

[GitHub] [incubator-seatunnel] BenJFan opened a new pull request #1567: [Feature][Connector] Change ClickhouseFile read temp data method to local file

BenJFan opened a new pull request #1567:
URL: https://github.com/apache/incubator-seatunnel/pull/1567


   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   change ClickhouseFile read temporary data method to local file.
   This close #1566 
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in you PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1567: [Feature][Connector] Change ClickhouseFile read temp data method to local file

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1567:
URL: https://github.com/apache/incubator-seatunnel/pull/1567#issuecomment-1080109692


   hi, can you update the code, the CI failure has been fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] BenJFan removed a comment on pull request #1567: [Feature][Connector] Change ClickhouseFile read temp data method to local file

Posted by GitBox <gi...@apache.org>.
BenJFan removed a comment on pull request #1567:
URL: https://github.com/apache/incubator-seatunnel/pull/1567#issuecomment-1080113992


   > hi, can you update the code, the CI failure has been fixed.
   
   ![image](https://user-images.githubusercontent.com/32387433/160315912-a97c5e1b-4605-48ca-aa5f-075a4e06ff5c.png)
   Seem like we should change ci license checker?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1567: [Feature][Connector] Change ClickhouseFile read temp data method to local file

Posted by GitBox <gi...@apache.org>.
BenJFan commented on pull request #1567:
URL: https://github.com/apache/incubator-seatunnel/pull/1567#issuecomment-1080113992


   > hi, can you update the code, the CI failure has been fixed.
   
   ![image](https://user-images.githubusercontent.com/32387433/160315912-a97c5e1b-4605-48ca-aa5f-075a4e06ff5c.png)
   Seem like we should change ci license checker?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1567: [Feature][Connector] Change ClickhouseFile read temp data method to local file

Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1567:
URL: https://github.com/apache/incubator-seatunnel/pull/1567


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org