[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24738: [WIP][SPARK-23098][SQL] Migrate Kafka Batch source to v2.

[GitBox <gi...@apache.org>]

gaborgsomogyi commented on a change in pull request #24738: [WIP][SPARK-23098][SQL] Migrate Kafka Batch source to v2.
URL: https://github.com/apache/spark/pull/24738#discussion_r295819450
 
 

 ##########
 File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
 ##########
 @@ -560,7 +587,15 @@ private[kafka010] object KafkaSourceProvider extends Logging {
       .build()
 
   /**
-   * Returns a unique consumer group (group.id), allowing the user to set the prefix of
+   * Returns a unique batch consumer group (group.id), allowing the user to set the prefix of
+   * the consumer group
+   */
+  private[kafka010] def batchUniqueGroupId(): String = {
+    s"spark-kafka-relation-${UUID.randomUUID}"
 
 Review comment:
   I think group ID configuration should be available on batch side as well but not yet added even if couple of lines. Don't want to mix up several intentions in this PR. I'm going to file another jira + PR  when this one merged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org