You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/09/27 09:52:00 UTC

[jira] [Commented] (IMPALA-10828) Impala 4.0 should pin to a specifit toolchain commit when building on ARM

    [ https://issues.apache.org/jira/browse/IMPALA-10828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17420628#comment-17420628 ] 

ASF subversion and git services commented on IMPALA-10828:
----------------------------------------------------------

Commit ef7de393325a5e9343e24e90f565697b03f25aac in impala's branch refs/heads/branch-4.0.1 from stiga-huang
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=ef7de39 ]

IMPALA-10828: Impala 4.0 should pin to a specifit toolchain commit when building on ARM

While building on ARM platform, bin/bootstrap_system.sh will compile
native-toolchain using the latest commit, which will cause build
failures if we are building branches other than master.

This patch addes a branch name (asf-impala-4.0) when cloning the
native-toolchain repo. So we can build Impala 4.0 on ARM without
manually modifying bin/bootstrap_system.sh.

Tests:
 - Tested on ARM platform.

Change-Id: Id353e0132b684a338e2c5454331be9bff9a8be14


> Impala 4.0 should pin to a specifit toolchain commit when building on ARM
> -------------------------------------------------------------------------
>
>                 Key: IMPALA-10828
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10828
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: Impala 4.0.0
>         Environment: aarch64
>            Reporter: Quanlong Huang
>            Assignee: Quanlong Huang
>            Priority: Major
>
> While building on ARM platform, bin/bootstrap_system.sh will compile native-toolchain:
> {code:bash}
> if [[ $ARCH_NAME == 'aarch64' ]]; then
>   echo -e "\nexport SKIP_TOOLCHAIN_BOOTSTRAP=true" >> \
>     "${IMPALA_HOME}/bin/impala-config-local.sh"
>   SET_TOOLCHAIN_HOME="export NATIVE_TOOLCHAIN_HOME=${IMPALA_HOME}/../native-toolchain"
>   echo -e "\n$SET_TOOLCHAIN_HOME" >> ~/.bashrc
>   echo -e "\n$SET_TOOLCHAIN_HOME" >> "${IMPALA_HOME}/bin/impala-config-local.sh"
>   eval "$SET_TOOLCHAIN_HOME"
>   if ! [[ -d "$NATIVE_TOOLCHAIN_HOME" ]]; then
>     time -p git clone https://github.com/cloudera/native-toolchain/ \
>       "$NATIVE_TOOLCHAIN_HOME"
>   fi
>   cd "$NATIVE_TOOLCHAIN_HOME"
>   git pull
>   echo "Begin build tool chain, may need several hours, please be patient...."
>   sudo chmod 755 ~/.cache
>   ./buildall.sh
>   cd -
>   mkdir -p ${IMPALA_HOME}/toolchain
> fi {code}
> However, it checks out the master branch of native-toolchain, which will result in compile errors. The corresponding commit should be 701500a90f2539a1d3f4ef3fe7546135b670f0a5.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org