[GitHub] [iceberg] pvary commented on issue #7034: Hive ping functionality seems to leak threads

["pvary (via GitHub)" <gi...@apache.org>]

pvary commented on issue #7034:
URL: https://github.com/apache/iceberg/issues/7034#issuecomment-1512427785

   > This might be fixed with : #6648 by @pvary . I see in [newest code](https://github.com/apache/iceberg/blob/master/hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreLock.java#L174) the code calls shutdown on exitingScheduledExecutorService. But in [earlier code](https://github.com/apache/iceberg/blob/apache-iceberg-1.1.0/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java#L383), it does not. Although I havent walked through it to be 100% sure.
   
   This was the exact issue with the Spark test which prompted me to add the `cancel` call to the release of the locks. Otherwise the Spark tests were failing with resource problems.
   
   The issue was highlighted by my change since the Locking change created threads on every commit instead on every TableOperation creation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org