You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Ernie Rael <er...@raelity.com> on 2020/03/30 14:49:38 UTC

proposed PR for 12.0 with changeset parentage issue

I did a PR, https://github.com/apache/netbeans/pull/2053, last night 
that fixes a couple problems with the "new maven project" dialog (an 
exception and a newly created project with a syntax error). I think the 
PR has the wrong parent (my bad); it's parent probably should be 
upstrem/master.

    @  changeset:   4122:a21deae90ed9
    |  bookmark:    ValidationsForMavenProjectCreation
    |  parent:      4102:a92abb562f42
    |  summary:     [NETBEANS-4083] Add missing validation in new maven
    project dialog
    |
    .....
    |
    o    changeset:   4102:a92abb562f42
    |\   bookmark:    release120
    | ~  tag:         12.0-beta2
    |    tag:         upstream/release120
    .....
    |
    o    changeset:   4101:4881ea11ed7b
    |\   tag:         upstream/master

I think this parentage issue, might be why the PR didn't hook up to the 
issue automagically. There are ways to hook up the PR to the issue 
manually, 
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue, 
but that's beyond my reach.

If there's something I need to do to clean this PR up, LMK.

-ernie


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists