[PR] [ZEPPELIN-3225] Add missing @Override annotations in zeppelin-server [zeppelin]

["kimyenac (via GitHub)" <gi...@apache.org>]

kimyenac opened a new pull request, #5359:
URL: https://github.com/apache/zeppelin/pull/5359

   ### What is this PR for?
   The original report is about missing @Override annotations in
   ActiveDirectoryGroupRealm. Those were already added by ZEPPELIN-5130, so the
   class is clean on current master.
   
   To close out the issue with something useful, I scanned the whole
   zeppelin-server module for methods that implement or override a supertype
   method without the annotation, and found seven remaining cases:
   
   * five `toJson()` implementations of `JsonSerializable`
     (`HeliumConf`, `NpmPackage`, `WebpackResult`, `WatcherMessage`,
     `CredentialsInfoSaving`)
   * `shouldSkipClass` and `shouldSkipField` in `JsonExclusionStrategy`,
     which implement Gson's `ExclusionStrategy`
   
   ### What type of PR is it?
   Improvement
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-3225
   
   ### How should this be tested?
   Annotation only change with no behaviour change, so the compiler is the check.
   `./mvnw compile -pl zeppelin-server` passes, RAT reports 0 unapproved licenses,
   and Checkstyle reports no new violations in the touched files.
   
   ### Questions:
   * Does the licenses files need update? No.
   * Is there breaking changes for older versions? No.
   * Does this needs documentation? No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-3225] Add missing @Override annotations in zeppelin-server [zeppelin]

["jongyoul (via GitHub)" <gi...@apache.org>]

jongyoul commented on PR #5359:
URL: https://github.com/apache/zeppelin/pull/5359#issuecomment-5167613855

   Merged into master (74fd0604).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-3225] Add missing @Override annotations in zeppelin-server [zeppelin]

["jongyoul (via GitHub)" <gi...@apache.org>]

jongyoul merged PR #5359:
URL: https://github.com/apache/zeppelin/pull/5359


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org