You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/19 18:55:33 UTC
[GitHub] [airflow] jmelot opened a new pull request #15959: Improve documentation and examples in example_asana.py
jmelot opened a new pull request #15959:
URL: https://github.com/apache/airflow/pull/15959
Clarifies how to override workspace or project values from the connection in the operator parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmelot commented on a change in pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
jmelot commented on a change in pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#discussion_r672236034
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Oh good point -- done! (that also reminded me to add some comments describing how the connection should be set up as well)
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Actually, this throws an import error when `ci_prepare_provider_documentation.sh` gets run -- switching back to os.environ.get for now, though will check around later and see if there's another way to resolve.
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Actually, this leads to an import error when `ci_prepare_provider_documentation.sh` gets run -- switching back to os.environ.get for now, though will check around later and see if there's another way to resolve.
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Hi @potiuk! [This](https://github.com/apache/airflow/runs/3103723424#step:6:449) is the error I saw. I can revert my previous commit so this error will get triggered again, if that would be useful, or let me know anything else I can do to help.
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Hi @potiuk! [This](https://github.com/apache/airflow/runs/3103723424#step:6:449) is the error I saw (tried to link to it but that doesn't seem to be working - it's line 449, I'll paste the stack trace below). I can revert my previous commit so this error will get triggered again, if that would be useful, or let me know anything else I can do to help.
```
Traceback (most recent call last):
File "/opt/airflow/dev/import_all_classes.py", line 77, in import_all_classes
_module = importlib.import_module(modinfo.name)
File "/usr/local/lib/python3.6/importlib/__init__.py", line 126, in
import_module
return _bootstrap._gcd_import(name, package, level)
File "<frozen importlib._bootstrap>", line 994, in _gcd_import
File "<frozen importlib._bootstrap>", line 971, in _find_and_load
File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 678, in exec_module
File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
File "/opt/airflow/airflow/providers/asana/example_dags/example_asana.py",
line 36, in <module>
ASANA_TASK_TO_UPDATE = os.environ["ASANA_TASK_TO_UPDATE"]
File "/usr/local/lib/python3.6/os.py", line 669, in __getitem__
raise KeyError(key) from None
KeyError: 'ASANA_TASK_TO_UPDATE'
----------------------------------------
########################################################################################################################
[IN CONTAINER] EXITING /opt/airflow/scripts/in_container/run_prepare_provider_documentation.sh WITH EXIT CODE 1
```
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Hi @potiuk! [This](https://github.com/apache/airflow/runs/3103723424#step:6:449) is the error I saw (tried to link to the relevant line but that doesn't seem to be working - it's line 449, I'll paste the stack trace below). I can revert my previous commit so this error will get triggered again, if that would be useful, or let me know anything else I can do to help.
```
Traceback (most recent call last):
File "/opt/airflow/dev/import_all_classes.py", line 77, in import_all_classes
_module = importlib.import_module(modinfo.name)
File "/usr/local/lib/python3.6/importlib/__init__.py", line 126, in
import_module
return _bootstrap._gcd_import(name, package, level)
File "<frozen importlib._bootstrap>", line 994, in _gcd_import
File "<frozen importlib._bootstrap>", line 971, in _find_and_load
File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 678, in exec_module
File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
File "/opt/airflow/airflow/providers/asana/example_dags/example_asana.py",
line 36, in <module>
ASANA_TASK_TO_UPDATE = os.environ["ASANA_TASK_TO_UPDATE"]
File "/usr/local/lib/python3.6/os.py", line 669, in __getitem__
raise KeyError(key) from None
KeyError: 'ASANA_TASK_TO_UPDATE'
----------------------------------------
########################################################################################################################
[IN CONTAINER] EXITING /opt/airflow/scripts/in_container/run_prepare_provider_documentation.sh WITH EXIT CODE 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#issuecomment-882780887
Rebuilding...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmelot commented on a change in pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
jmelot commented on a change in pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#discussion_r672265091
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Actually, this throws an import error when `ci_prepare_provider_documentation.sh` gets run -- switching back to os.environ.get for now, though will check around later and see if there's another way to resolve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmelot commented on pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
jmelot commented on pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#issuecomment-882213264
Hi @ephraimbuddy, thanks for your comment above and sorry it was so long before I was able to get back to this. I added a system test. Please let me know if you have other suggestions or I need to make other modifications!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#discussion_r671973215
##########
File path: tests/providers/asana/operators/test_asana_system.py
##########
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import os
+
+import pytest
+
+from tests.test_utils import AIRFLOW_MAIN_FOLDER
+from tests.test_utils.system_tests_class import SystemTest
+
+DAG_FOLDER = os.path.join(AIRFLOW_MAIN_FOLDER, "airflow", "providers", "asana", "example_dags")
+
+
+@pytest.mark.system("asana")
+class AsanaExampleDagsSystemTest(SystemTest):
+ def test_run_example_dag_asana(self):
+ self.run_dag("example_asana", DAG_FOLDER)
Review comment:
I might be wrong but I don’t think we need to test the example DAG
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#discussion_r671973215
##########
File path: tests/providers/asana/operators/test_asana_system.py
##########
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import os
+
+import pytest
+
+from tests.test_utils import AIRFLOW_MAIN_FOLDER
+from tests.test_utils.system_tests_class import SystemTest
+
+DAG_FOLDER = os.path.join(AIRFLOW_MAIN_FOLDER, "airflow", "providers", "asana", "example_dags")
+
+
+@pytest.mark.system("asana")
+class AsanaExampleDagsSystemTest(SystemTest):
+ def test_run_example_dag_asana(self):
+ self.run_dag("example_asana", DAG_FOLDER)
Review comment:
We should probably refactor this a bit to avoid duplicate code. That’s something for another PR though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#discussion_r672267649
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Hmm. Strange. Should not do that :)
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
can you point me to the error :) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#discussion_r671973020
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Is `None` an acceptable value for any of these? If not, it’s better to use `os.environ["ASANA_TASK_TO_UPDATE"]` etc. instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmelot commented on a change in pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
jmelot commented on a change in pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#discussion_r672236034
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Oh good point -- done! (that also reminded me to add some comments describing how the connection should be set up as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmelot commented on a change in pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
jmelot commented on a change in pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#discussion_r672749007
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Hi @potiuk! [This](https://github.com/apache/airflow/runs/3103723424#step:6:449) is the error I saw (tried to link to it but that doesn't seem to be working - it's line 449, I'll paste the stack trace below). I can revert my previous commit so this error will get triggered again, if that would be useful, or let me know anything else I can do to help.
```
Traceback (most recent call last):
File "/opt/airflow/dev/import_all_classes.py", line 77, in import_all_classes
_module = importlib.import_module(modinfo.name)
File "/usr/local/lib/python3.6/importlib/__init__.py", line 126, in
import_module
return _bootstrap._gcd_import(name, package, level)
File "<frozen importlib._bootstrap>", line 994, in _gcd_import
File "<frozen importlib._bootstrap>", line 971, in _find_and_load
File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 678, in exec_module
File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
File "/opt/airflow/airflow/providers/asana/example_dags/example_asana.py",
line 36, in <module>
ASANA_TASK_TO_UPDATE = os.environ["ASANA_TASK_TO_UPDATE"]
File "/usr/local/lib/python3.6/os.py", line 669, in __getitem__
raise KeyError(key) from None
KeyError: 'ASANA_TASK_TO_UPDATE'
----------------------------------------
########################################################################################################################
[IN CONTAINER] EXITING /opt/airflow/scripts/in_container/run_prepare_provider_documentation.sh WITH EXIT CODE 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#issuecomment-881778749
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmelot commented on a change in pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
jmelot commented on a change in pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#discussion_r672749007
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Hi @potiuk! [This](https://github.com/apache/airflow/runs/3103723424#step:6:449) is the error I saw. I can revert my previous commit so this error will get triggered again, if that would be useful, or let me know anything else I can do to help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmelot commented on a change in pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
jmelot commented on a change in pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#discussion_r672749007
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Hi @potiuk! [This](https://github.com/apache/airflow/runs/3103723424#step:6:449) is the error I saw (tried to link to the relevant line but that doesn't seem to be working - it's line 449, I'll paste the stack trace below). I can revert my previous commit so this error will get triggered again, if that would be useful, or let me know anything else I can do to help.
```
Traceback (most recent call last):
File "/opt/airflow/dev/import_all_classes.py", line 77, in import_all_classes
_module = importlib.import_module(modinfo.name)
File "/usr/local/lib/python3.6/importlib/__init__.py", line 126, in
import_module
return _bootstrap._gcd_import(name, package, level)
File "<frozen importlib._bootstrap>", line 994, in _gcd_import
File "<frozen importlib._bootstrap>", line 971, in _find_and_load
File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 678, in exec_module
File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
File "/opt/airflow/airflow/providers/asana/example_dags/example_asana.py",
line 36, in <module>
ASANA_TASK_TO_UPDATE = os.environ["ASANA_TASK_TO_UPDATE"]
File "/usr/local/lib/python3.6/os.py", line 669, in __getitem__
raise KeyError(key) from None
KeyError: 'ASANA_TASK_TO_UPDATE'
----------------------------------------
########################################################################################################################
[IN CONTAINER] EXITING /opt/airflow/scripts/in_container/run_prepare_provider_documentation.sh WITH EXIT CODE 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#issuecomment-882780887
Rebuilding...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #15959:
URL: https://github.com/apache/airflow/pull/15959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#discussion_r672267649
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Hmm. Strange. Should not do that :)
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
can you point me to the error :) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmelot commented on a change in pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
jmelot commented on a change in pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#discussion_r672265091
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Actually, this leads to an import error when `ci_prepare_provider_documentation.sh` gets run -- switching back to os.environ.get for now, though will check around later and see if there's another way to resolve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#issuecomment-882780887
Rebuilding...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#discussion_r672268197
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
can you point me to the error :) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #15959:
URL: https://github.com/apache/airflow/pull/15959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #15959:
URL: https://github.com/apache/airflow/pull/15959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmelot commented on a change in pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
jmelot commented on a change in pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#discussion_r672236034
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Oh good point -- done! (that also reminded me to add some comments describing how the connection should be set up as well)
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Actually, this throws an import error when `ci_prepare_provider_documentation.sh` gets run -- switching back to os.environ.get for now, though will check around later and see if there's another way to resolve.
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Actually, this leads to an import error when `ci_prepare_provider_documentation.sh` gets run -- switching back to os.environ.get for now, though will check around later and see if there's another way to resolve.
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Hi @potiuk! [This](https://github.com/apache/airflow/runs/3103723424#step:6:449) is the error I saw. I can revert my previous commit so this error will get triggered again, if that would be useful, or let me know anything else I can do to help.
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Hi @potiuk! [This](https://github.com/apache/airflow/runs/3103723424#step:6:449) is the error I saw (tried to link to it but that doesn't seem to be working - it's line 449, I'll paste the stack trace below). I can revert my previous commit so this error will get triggered again, if that would be useful, or let me know anything else I can do to help.
```
Traceback (most recent call last):
File "/opt/airflow/dev/import_all_classes.py", line 77, in import_all_classes
_module = importlib.import_module(modinfo.name)
File "/usr/local/lib/python3.6/importlib/__init__.py", line 126, in
import_module
return _bootstrap._gcd_import(name, package, level)
File "<frozen importlib._bootstrap>", line 994, in _gcd_import
File "<frozen importlib._bootstrap>", line 971, in _find_and_load
File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 678, in exec_module
File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
File "/opt/airflow/airflow/providers/asana/example_dags/example_asana.py",
line 36, in <module>
ASANA_TASK_TO_UPDATE = os.environ["ASANA_TASK_TO_UPDATE"]
File "/usr/local/lib/python3.6/os.py", line 669, in __getitem__
raise KeyError(key) from None
KeyError: 'ASANA_TASK_TO_UPDATE'
----------------------------------------
########################################################################################################################
[IN CONTAINER] EXITING /opt/airflow/scripts/in_container/run_prepare_provider_documentation.sh WITH EXIT CODE 1
```
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Hi @potiuk! [This](https://github.com/apache/airflow/runs/3103723424#step:6:449) is the error I saw (tried to link to the relevant line but that doesn't seem to be working - it's line 449, I'll paste the stack trace below). I can revert my previous commit so this error will get triggered again, if that would be useful, or let me know anything else I can do to help.
```
Traceback (most recent call last):
File "/opt/airflow/dev/import_all_classes.py", line 77, in import_all_classes
_module = importlib.import_module(modinfo.name)
File "/usr/local/lib/python3.6/importlib/__init__.py", line 126, in
import_module
return _bootstrap._gcd_import(name, package, level)
File "<frozen importlib._bootstrap>", line 994, in _gcd_import
File "<frozen importlib._bootstrap>", line 971, in _find_and_load
File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 678, in exec_module
File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
File "/opt/airflow/airflow/providers/asana/example_dags/example_asana.py",
line 36, in <module>
ASANA_TASK_TO_UPDATE = os.environ["ASANA_TASK_TO_UPDATE"]
File "/usr/local/lib/python3.6/os.py", line 669, in __getitem__
raise KeyError(key) from None
KeyError: 'ASANA_TASK_TO_UPDATE'
----------------------------------------
########################################################################################################################
[IN CONTAINER] EXITING /opt/airflow/scripts/in_container/run_prepare_provider_documentation.sh WITH EXIT CODE 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #15959:
URL: https://github.com/apache/airflow/pull/15959#discussion_r672267649
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -31,46 +33,62 @@
"owner": "airflow",
}
+ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
+ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_PROJECT_ID = os.environ.get("ASANA_PROJECT_ID")
+CONN_ID = os.environ.get("ASANA_CONNECTION_ID")
Review comment:
Hmm. Strange. Should not do that :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #15959: Improve documentation and examples in example_asana.py
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #15959:
URL: https://github.com/apache/airflow/pull/15959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org