You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/08/31 01:11:18 UTC

[GitHub] [hudi] wangxianghu commented on pull request #2055: [HUDI-1253] Merge two TestHoodieSnapshotExporter to one class

wangxianghu commented on pull request #2055:
URL: https://github.com/apache/hudi/pull/2055#issuecomment-683501153


   > Hi @wangxianghu thanks for the changes. The split was intended for distinguishing between unit test and functional tests. Please see this ticket https://issues.apache.org/jira/browse/HUDI-994
   > When we use `@Tag("functional")` it means the whole test class will be included in a test suite to be run with `-Pfunctional-tests`. The class you deleted here is a pure unit test hence it'd better stay as is. We'll probably come up with a guide about testing here.
   
   Hi, @xushiyan thanks for your explanation.  closing this now


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org