[GitHub] [lucene] mocobeta commented on a change in pull request #671: Add custom composite action to set up CI environments

[GitBox <gi...@apache.org>]

mocobeta commented on a change in pull request #671:
URL: https://github.com/apache/lucene/pull/671#discussion_r803409108



##########
File path: .github/workflows/gradle-precommit.yml
##########
@@ -26,12 +26,9 @@ jobs:
     steps:
     - uses: actions/checkout@v2
 
-    - name: Set up JDK
-      uses: actions/setup-java@v2
+    - uses: ./.github/actions/setup-action
       with:
-        distribution: 'adopt-hotspot'
         java-version: ${{ matrix.java }}

Review comment:
       I don't think the strategy matrix can be shared across workflows. If the target Java versions have to be hard-coded in workflow files anyway, the shared action in this PR wouldn't be much help for us. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org