You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by et...@apache.org on 2008/03/14 19:53:59 UTC
svn commit: r637211 - in
/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets:
GadgetSpecFetcher.java MessageBundleFetcher.java
Author: etnu
Date: Fri Mar 14 11:53:58 2008
New Revision: 637211
URL: http://svn.apache.org/viewvc?rev=637211&view=rev
Log:
Fixed improper cache lookup code in fetchers. We still need to provide more production worthy caches in the default implementations here.
Modified:
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetSpecFetcher.java
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/MessageBundleFetcher.java
Modified: incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetSpecFetcher.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetSpecFetcher.java?rev=637211&r1=637210&r2=637211&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetSpecFetcher.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetSpecFetcher.java Fri Mar 14 11:53:58 2008
@@ -52,7 +52,7 @@
public GadgetSpec fetch(URI url, boolean forceReload) throws GadgetException {
GadgetSpec spec = null;
if (!forceReload) {
- cache.get(url);
+ spec = cache.get(url);
}
if (spec == null) {
RemoteContentRequest request = new RemoteContentRequest(url);
Modified: incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/MessageBundleFetcher.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/MessageBundleFetcher.java?rev=637211&r1=637210&r2=637211&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/MessageBundleFetcher.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/MessageBundleFetcher.java Fri Mar 14 11:53:58 2008
@@ -53,7 +53,7 @@
throws GadgetException {
MessageBundle bundle = null;
if (!forceReload) {
- cache.get(url);
+ bundle = cache.get(url);
}
if (bundle == null) {
RemoteContentRequest request = new RemoteContentRequest(url);