You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/06 22:48:29 UTC
[GitHub] [airflow] DerekHeldtWerle opened a new pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations
DerekHeldtWerle opened a new pull request #15238:
URL: https://github.com/apache/airflow/pull/15238
# Overview
This PR adds a new field (`airflowConfigAnnotations`) that allows users to add `annotations` to the main `configmap.yaml` file.
I ended up setting up a new testing file as I didn't find a file where this specifically fit, but if it should be moved elsewhere let me know.
related: https://github.com/apache/airflow/issues/13643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] DerekHeldtWerle commented on a change in pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations
Posted by GitBox <gi...@apache.org>.
DerekHeldtWerle commented on a change in pull request #15238:
URL: https://github.com/apache/airflow/pull/15238#discussion_r608240818
##########
File path: docs/helm-chart/parameters-ref.rst
##########
@@ -66,6 +66,12 @@ The following tables lists the configurable parameters of the Airflow chart and
* - ``airflowHome``
- Location of airflow home directory
- ``1``
+ * - ``airflowPodAnnotations``
+ - Extra annotations to apply to all Airflow pods.
+ - ``{}``
+ * - ``airflowConfigAnnotations``
+ - Extra annotations to apply to the main Airflow configs.
Review comment:
I think `configmap` would be more appropriate than the plural here as these annotations don't get propagated out to other configmaps (`extra-configmaps`, `statsd-configmap`, and `webserver-configmap`). Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations
Posted by GitBox <gi...@apache.org>.
FloChehab commented on pull request #15238:
URL: https://github.com/apache/airflow/pull/15238#issuecomment-829027604
> @FloChehab Can you look at it?
Hello, out of curiosity, what can be the purposes of configurable annotations on (this) ConfigMap ?
Otherwise, this looks good to me, except the values name since we have multiple configmaps, etc. But I don't have a better suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #15238:
URL: https://github.com/apache/airflow/pull/15238#issuecomment-814493510
@FloChehab Can you look at it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] DerekHeldtWerle commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations
Posted by GitBox <gi...@apache.org>.
DerekHeldtWerle commented on pull request #15238:
URL: https://github.com/apache/airflow/pull/15238#issuecomment-834524795
Hey @kaxil, anything else need changing to get this merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15238:
URL: https://github.com/apache/airflow/pull/15238#issuecomment-814499944
[The Workflow run](https://github.com/apache/airflow/actions/runs/724207316) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15238:
URL: https://github.com/apache/airflow/pull/15238#issuecomment-814499784
[The Workflow run](https://github.com/apache/airflow/actions/runs/724204103) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15238:
URL: https://github.com/apache/airflow/pull/15238#discussion_r608239035
##########
File path: docs/helm-chart/parameters-ref.rst
##########
@@ -66,6 +66,12 @@ The following tables lists the configurable parameters of the Airflow chart and
* - ``airflowHome``
- Location of airflow home directory
- ``1``
+ * - ``airflowPodAnnotations``
+ - Extra annotations to apply to all Airflow pods.
+ - ``{}``
+ * - ``airflowConfigAnnotations``
+ - Extra annotations to apply to the main Airflow configs.
Review comment:
```suggestion
* - ``airflowConfigAnnotations``
- Extra annotations to apply to the main Airflow configsmaps.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #15238:
URL: https://github.com/apache/airflow/pull/15238#issuecomment-829493407
@DerekHeldtWerle Can you fix the failing static checks please: https://github.com/apache/airflow/pull/15238/checks?check_run_id=2301349726#step:10:245
```diff
diff --git a/chart/tests/test_configmap.py b/chart/tests/test_configmap.py
index a58f72a..6a9e286 100644
--- a/chart/tests/test_configmap.py
+++ b/chart/tests/test_configmap.py
@@ -26,9 +26,7 @@ class ConfigmapTest(unittest.TestCase):
def test_single_annotation(self):
docs = render_chart(
values={
- "airflowConfigAnnotations": {
- "key": "value"
- },
+ "airflowConfigAnnotations": {"key": "value"},
},
show_only=["templates/configmaps/configmap.yaml"],
)
@@ -39,10 +37,7 @@ class ConfigmapTest(unittest.TestCase):
def test_multiple_annotations(self):
docs = render_chart(
values={
- "airflowConfigAnnotations": {
- "key": "value",
- "key-two": "value-two"
- },
+ "airflowConfigAnnotations": {"key": "value", "key-two": "value-two"},
},
show_only=["templates/configmaps/configmap.yaml"],
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] DerekHeldtWerle commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations
Posted by GitBox <gi...@apache.org>.
DerekHeldtWerle commented on pull request #15238:
URL: https://github.com/apache/airflow/pull/15238#issuecomment-829593227
@FloChehab in our multi-tenant setup, airflow dags run in each teams namespace. With these annotations, we can easily replicate the airflow configmap to each namespace through [kubed](https://github.com/kubeops-tools/kubed) so that the task pods can run properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15238:
URL: https://github.com/apache/airflow/pull/15238#issuecomment-831415142
[The Workflow run](https://github.com/apache/airflow/actions/runs/807577092) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] DerekHeldtWerle commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations
Posted by GitBox <gi...@apache.org>.
DerekHeldtWerle commented on pull request #15238:
URL: https://github.com/apache/airflow/pull/15238#issuecomment-825736602
Hey @kaxil, anything else that needs to be addressed for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15238:
URL: https://github.com/apache/airflow/pull/15238#issuecomment-829494527
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15238:
URL: https://github.com/apache/airflow/pull/15238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org