You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/06/13 15:08:51 UTC

[GitHub] [arrow-datafusion] jackwener opened a new pull request, #6660: refactor: unify replace count(*) analyzer by removing it in sql crate

jackwener opened a new pull request, #6660:
URL: https://github.com/apache/arrow-datafusion/pull/6660

   fix: CountWildcardRule ignore Expr::Alias
   
   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   
   - unify replace count(*) analyzer by removing it in sql crate
   - fix: CountWildcardRule ignore Expr::Alias
   
   # Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jackwener merged pull request #6660: refactor: unify replace count(*) analyzer by removing it in sql crate

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #6660:
URL: https://github.com/apache/arrow-datafusion/pull/6660


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #6660: refactor: unify replace count(*) analyzer by removing it in sql crate

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6660:
URL: https://github.com/apache/arrow-datafusion/pull/6660#issuecomment-1589983488

   cc @jiangzhx who did some related work on  https://github.com/apache/arrow-datafusion/pull/5518 I think


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #6660: refactor: unify replace count(*) analyzer by removing it in sql crate

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on code in PR #6660:
URL: https://github.com/apache/arrow-datafusion/pull/6660#discussion_r1228305248


##########
datafusion/sql/tests/integration_test.rs:
##########
@@ -881,7 +881,7 @@ fn select_aggregate_with_having_referencing_column_not_in_select() {
     assert_eq!(
         "Plan(\"HAVING clause references non-aggregate values: \
             Expression person.first_name could not be resolved from available columns: \
-            COUNT(UInt8(1))\")",
+            COUNT(*)\")",

Review Comment:
   sql-crate don't replace `count(*)`.
   we use rule to replace unified `count(*)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org