[GitHub] [nifi] exceptionfactory commented on pull request #5905: NIFI-9817 Add a Validator for the PutCloudWatchMetric Processor's Unit Field

[GitBox <gi...@apache.org>]

exceptionfactory commented on PR #5905:
URL: https://github.com/apache/nifi/pull/5905#issuecomment-1192839161

   > Thank you for your recent changes @patalwell! It's a more robust one, I like it. However it is lacking the empty string as a valid unit which was supported in the previous version. I've added a test suggestion to ensure that we support it and backward compatibility is not affected.
   > 
   > Edit: Before accepting my suggestion... This review was based on the recent changes. But after checking again the original code, I see that empty unit was not allowed because NON_EMPTY_VALIDATOR was used. Probably I missed that in your original change. Now I'm a bit confused and I'm not sure which one was your intention.
   
   Thanks for persevering through the feedback @patalwell, I think this is just about good to go!
   
   @nandorsoma As you noted, the `NON_EMPTY_VALIDATOR` would prohibit an empty value for the unit. With that fact, do you have any additional feedback?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org